Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_stop_planner): remove no_height_pointcloud_ptr in filtering pointcloud #2623

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Jan 10, 2023

Description

TIERIV_INTERNAL_LINK: https://tier4.atlassian.net/browse/T4PB-24714

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 10, 2023
@h-ohta h-ohta changed the title fix(obstacle_stop_planner): fix point.z in filtering pointcloud fix(obstacle_stop_planner): remove no_height_pointcloud_ptr in filtering pointcloud Jan 10, 2023
@h-ohta h-ohta force-pushed the fix/obstacle_point_z branch from 6afd55c to c9cbebd Compare January 10, 2023 06:55
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 11.39% // Head: 11.47% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (c9cbebd) compared to base (33ecdb5).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head c9cbebd differs from pull request most recent head 04d46b3. Consider uploading reports for the commit 04d46b3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
+ Coverage   11.39%   11.47%   +0.07%     
==========================================
  Files        1279     1271       -8     
  Lines       89170    88613     -557     
  Branches    23587    23314     -273     
==========================================
+ Hits        10161    10165       +4     
+ Misses      68239    67677     -562     
- Partials    10770    10771       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.49% <ø> (+0.10%) ⬆️ Carriedforward from 9b8d079

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_stop_planner/src/node.cpp 0.00% <0.00%> (ø)
control/mpc_lateral_controller/src/mpc.cpp 47.05% <0.00%> (ø)
control/pid_longitudinal_controller/src/pid.cpp 92.15% <0.00%> (ø)
control/mpc_lateral_controller/src/mpc_utils.cpp 57.27% <0.00%> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp 0.00% <0.00%> (ø)
control/mpc_lateral_controller/src/interpolate.cpp 71.42% <0.00%> (ø)
...trol/mpc_lateral_controller/src/lowpass_filter.cpp 90.16% <0.00%> (ø)
...trol/mpc_lateral_controller/src/mpc_trajectory.cpp 81.25% <0.00%> (ø)
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
... and 65 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta enabled auto-merge (squash) January 12, 2023 09:27
@h-ohta h-ohta merged commit e77bc20 into autowarefoundation:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants