-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(obstacle_stop_planner): remove no_height_pointcloud_ptr
in filtering pointcloud
#2623
Conversation
no_height_pointcloud_ptr
in filtering pointcloud
6afd55c
to
c9cbebd
Compare
Codecov ReportBase: 11.39% // Head: 11.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
==========================================
+ Coverage 11.39% 11.47% +0.07%
==========================================
Files 1279 1271 -8
Lines 89170 88613 -557
Branches 23587 23314 -273
==========================================
+ Hits 10161 10165 +4
+ Misses 68239 67677 -562
- Partials 10770 10771 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
no_height_pointcloud_ptr
in filtering pointcloudhttps://github.com/autowarefoundation/autoware.universe/blob/main/planning/obstacle_stop_planner/src/node.cpp#L871-L876
TIERIV_INTERNAL_LINK: https://tier4.atlassian.net/browse/T4PB-24714
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.