-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(trajectory_followers): cosmetic changes #2620
refactor(trajectory_followers): cosmetic changes #2620
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved in advance. This comment must be resolved though.
control/pid_longitudinal_controller/src/pid_longitudinal_controller.cpp
Outdated
Show resolved
Hide resolved
control/pid_longitudinal_controller/src/pid_longitudinal_controller.cpp
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 11.49% // Head: 12.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
+ Coverage 11.49% 12.12% +0.62%
==========================================
Files 1271 1271
Lines 88413 89347 +934
Branches 23314 23909 +595
==========================================
+ Hits 10163 10829 +666
- Misses 67480 67543 +63
- Partials 10770 10975 +205
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Minor refactors
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.