Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(trajectory_followers): cosmetic changes #2620

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jan 8, 2023

Description

Minor refactors

  • remove unused code
  • shrink namespace code

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested review from takayuki5168 and a team as code owners January 8, 2023 10:37
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Jan 8, 2023
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved in advance. This comment must be resolved though.

@TakaHoribe TakaHoribe enabled auto-merge (squash) January 11, 2023 01:49
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 11.49% // Head: 12.12% // Increases project coverage by +0.62% 🎉

Coverage data is based on head (8ed2e95) compared to base (132c154).
Patch coverage: 67.74% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2620      +/-   ##
==========================================
+ Coverage   11.49%   12.12%   +0.62%     
==========================================
  Files        1271     1271              
  Lines       88413    89347     +934     
  Branches    23314    23909     +595     
==========================================
+ Hits        10163    10829     +666     
- Misses      67480    67543      +63     
- Partials    10770    10975     +205     
Flag Coverage Δ *Carryforward flag
differential 47.44% <68.75%> (?)
total 11.49% <62.50%> (ø) Carriedforward from 132c154

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._controller/include/mpc_lateral_controller/mpc.hpp 44.82% <ø> (-1.84%) ⬇️
...pc_lateral_controller/qp_solver/qp_solver_osqp.hpp 0.00% <ø> (ø)
...l_controller/qp_solver/qp_solver_unconstr_fast.hpp 100.00% <ø> (ø)
...r/vehicle_model/vehicle_model_bicycle_dynamics.hpp 100.00% <ø> (ø)
...vehicle_model/vehicle_model_bicycle_kinematics.hpp 100.00% <ø> (ø)
...odel/vehicle_model_bicycle_kinematics_no_delay.hpp 100.00% <ø> (ø)
control/mpc_lateral_controller/src/interpolate.cpp 76.81% <0.00%> (+5.38%) ⬆️
control/mpc_lateral_controller/src/mpc.cpp 54.45% <0.00%> (+7.39%) ⬆️
..._lateral_controller/src/mpc_lateral_controller.cpp 43.66% <0.00%> (+8.56%) ⬆️
...trol/mpc_lateral_controller/src/mpc_trajectory.cpp 84.00% <ø> (+2.75%) ⬆️
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit d6e96a8 into autowarefoundation:main Jan 11, 2023
@TakaHoribe TakaHoribe deleted the refactor-controller branch January 11, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants