-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mission_planner): refine goal pose with parameter and add config file #2603
feat(mission_planner): refine goal pose with parameter and add config file #2603
Conversation
46d6b61
to
763d14e
Compare
9be4914
to
d0c3d9f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
==========================================
- Coverage 11.93% 11.55% -0.39%
==========================================
Files 1321 1314 -7
Lines 91855 92803 +948
Branches 24467 24999 +532
==========================================
- Hits 10965 10724 -241
- Misses 69529 70813 +1284
+ Partials 11361 11266 -95
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
planning/mission_planner/src/lanelet2_plugins/default_planner.cpp
Outdated
Show resolved
Hide resolved
d0c3d9f
to
38ff2a3
Compare
planning/mission_planner/src/lanelet2_plugins/utility_functions.cpp
Outdated
Show resolved
Hide resolved
planning/mission_planner/src/lanelet2_plugins/default_planner.hpp
Outdated
Show resolved
Hide resolved
planning/mission_planner/src/lanelet2_plugins/utility_functions.cpp
Outdated
Show resolved
Hide resolved
planning/mission_planner/src/lanelet2_plugins/utility_functions.cpp
Outdated
Show resolved
Hide resolved
planning/mission_planner/src/lanelet2_plugins/utility_functions.cpp
Outdated
Show resolved
Hide resolved
38ff2a3
to
8070e9b
Compare
planning/mission_planner/src/lanelet2_plugins/default_planner.cpp
Outdated
Show resolved
Hide resolved
c00c007
to
02a987f
Compare
d448f41
to
145f67f
Compare
@takayuki5168 Hi, sorry for late. I also added config file for mission planner . Can you check it? |
planning/mission_planner/src/lanelet2_plugins/default_planner.cpp
Outdated
Show resolved
Hide resolved
planning/mission_planner/src/lanelet2_plugins/default_planner.cpp
Outdated
Show resolved
Hide resolved
planning/mission_planner/src/lanelet2_plugins/default_planner.cpp
Outdated
Show resolved
Hide resolved
planning/mission_planner/src/lanelet2_plugins/default_planner.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ismetatabay Thank you for the fix. I left some additional comments but give you approval beforehand.
145f67f
to
5d9eb3f
Compare
@takayuki5168 thanks for the review, i updated the branch with your suggestions 👍 . |
LGTM |
5d9eb3f
to
572e490
Compare
e4c3adc
to
50dc8bc
Compare
Signed-off-by: ismetatabay <ismet@leodrive.ai> Signed-off-by: ismet <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai> Signed-off-by: ismet <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai> Signed-off-by: ismet <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai> Signed-off-by: ismet <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai> Signed-off-by: ismet <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai> Signed-off-by: ismet <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai> Signed-off-by: ismet <ismet@leodrive.ai>
50dc8bc
to
f7187fc
Compare
Description
This PR adds config file to mission_planner and parameter for refining goal pose in order to skip goal validation step. If added parameter is set to true, then given goal is refined according to the closest lane orientation.
autoware_launch PR (must be merged with this PR): autowarefoundation/autoware_launch#225
Tests performed
2023-01-16.16-19-02.mp4
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.