Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner): refine goal pose with parameter and add config file #2603

Merged
merged 7 commits into from
Mar 7, 2023

Conversation

ismetatabay
Copy link
Member

@ismetatabay ismetatabay commented Dec 30, 2022

Description

This PR adds config file to mission_planner and parameter for refining goal pose in order to skip goal validation step. If added parameter is set to true, then given goal is refined according to the closest lane orientation.

autoware_launch PR (must be merged with this PR): autowarefoundation/autoware_launch#225

Tests performed

2023-01-16.16-19-02.mp4

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 30, 2022
@ismetatabay ismetatabay changed the title correct goal pose feat(mission_planner): correct goal pose Dec 30, 2022
@ismetatabay ismetatabay force-pushed the feat/refine_goal_pose branch 2 times, most recently from 46d6b61 to 763d14e Compare December 30, 2022 14:37
@ismetatabay ismetatabay force-pushed the feat/refine_goal_pose branch 3 times, most recently from 9be4914 to d0c3d9f Compare January 16, 2023 13:45
@ismetatabay ismetatabay changed the title feat(mission_planner): correct goal pose feat(mission_planner): refine goal pose with parameter Jan 16, 2023
@ismetatabay ismetatabay marked this pull request as ready for review January 16, 2023 13:56
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Patch coverage: 3.12% and project coverage change: -0.39 ⚠️

Comparison is base (8814cca) 11.93% compared to head (e4c3adc) 11.55%.

❗ Current head e4c3adc differs from pull request most recent head f7187fc. Consider uploading reports for the commit f7187fc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2603      +/-   ##
==========================================
- Coverage   11.93%   11.55%   -0.39%     
==========================================
  Files        1321     1314       -7     
  Lines       91855    92803     +948     
  Branches    24467    24999     +532     
==========================================
- Hits        10965    10724     -241     
- Misses      69529    70813    +1284     
+ Partials    11361    11266      -95     
Flag Coverage Δ *Carryforward flag
differential 20.20% <3.12%> (?)
total 11.53% <ø> (-0.41%) ⬇️ Carriedforward from 572e490

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...planner/src/lanelet2_plugins/utility_functions.cpp 20.45% <0.00%> (-8.58%) ⬇️
...n_planner/src/lanelet2_plugins/default_planner.cpp 23.00% <5.26%> (-1.60%) ⬇️
...vehicle_model/vehicle_model_bicycle_kinematics.cpp 52.17% <0.00%> (-39.50%) ⬇️
...lude/obstacle_avoidance_planner/common_structs.hpp 22.22% <0.00%> (-26.35%) ⬇️
...terpolation/src/spline_interpolation_points_2d.cpp 35.05% <0.00%> (-15.45%) ⬇️
planning/obstacle_avoidance_planner/src/node.cpp 0.11% <0.00%> (-13.47%) ⬇️
common/osqp_interface/src/osqp_interface.cpp 36.84% <0.00%> (-13.16%) ⬇️
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 32.79% <0.00%> (-10.99%) ⬇️
...nner/src/vehicle_model/vehicle_model_interface.cpp 75.00% <0.00%> (-10.72%) ⬇️
...clude/obstacle_avoidance_planner/mpt_optimizer.hpp 80.00% <0.00%> (-4.62%) ⬇️
... and 128 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ismetatabay ismetatabay force-pushed the feat/refine_goal_pose branch from d0c3d9f to 38ff2a3 Compare January 17, 2023 09:49
@ismetatabay ismetatabay force-pushed the feat/refine_goal_pose branch from 38ff2a3 to 8070e9b Compare January 17, 2023 09:57
@ismetatabay ismetatabay force-pushed the feat/refine_goal_pose branch 2 times, most recently from c00c007 to 02a987f Compare February 22, 2023 12:05
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Feb 22, 2023
@ismetatabay ismetatabay changed the title feat(mission_planner): refine goal pose with parameter feat(mission_planner): refine goal pose with parameter and add config file Feb 22, 2023
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Feb 22, 2023
@ismetatabay ismetatabay force-pushed the feat/refine_goal_pose branch 2 times, most recently from d448f41 to 145f67f Compare February 22, 2023 13:42
@ismetatabay
Copy link
Member Author

ismetatabay commented Feb 22, 2023

@takayuki5168 Hi, sorry for late. I also added config file for mission planner . Can you check it?

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ismetatabay Thank you for the fix. I left some additional comments but give you approval beforehand.

@ismetatabay ismetatabay force-pushed the feat/refine_goal_pose branch from 145f67f to 5d9eb3f Compare February 24, 2023 09:49
@ismetatabay
Copy link
Member Author

@takayuki5168 thanks for the review, i updated the branch with your suggestions 👍 .

@takayuki5168
Copy link
Contributor

LGTM

@ismetatabay ismetatabay force-pushed the feat/refine_goal_pose branch from 5d9eb3f to 572e490 Compare February 27, 2023 18:48
@BonoloAWF BonoloAWF linked an issue Mar 6, 2023 that may be closed by this pull request
5 tasks
@ismetatabay ismetatabay force-pushed the feat/refine_goal_pose branch from e4c3adc to 50dc8bc Compare March 7, 2023 12:27
Signed-off-by: ismetatabay <ismet@leodrive.ai>
Signed-off-by: ismet <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai>
Signed-off-by: ismet <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai>
Signed-off-by: ismet <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai>
Signed-off-by: ismet <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai>
Signed-off-by: ismet <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai>
Signed-off-by: ismet <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai>
Signed-off-by: ismet <ismet@leodrive.ai>
@ismetatabay ismetatabay force-pushed the feat/refine_goal_pose branch from 50dc8bc to f7187fc Compare March 7, 2023 12:29
@xmfcx xmfcx merged commit b2a43c7 into autowarefoundation:main Mar 7, 2023
@ismetatabay ismetatabay deleted the feat/refine_goal_pose branch May 20, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config file for mission_planner
5 participants