Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): lane change topic hz drop #2545

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Signed-off-by: Muhammad Zulfaqar Azmi zulfaqar.azmi@tier4.jp

Description

The lane change module resamples candidate path starting from start of lane changing point to the end of the target lane (or to the goal). Due to the size of resampling, the candidate path publishing rate decreases, causing the module to be slow. This PR aims to solve this by resampling the path only between lane changing start point to lane changing end point.

Related links

Tests performed

check the lane change path candidate publishing rate. It shouldn't drop very much.

ros2 topic hz /planning/path_candidate/lane_change

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 10.55% // Head: 10.54% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f2fabfe) compared to base (3b6f48d).
Patch has no changes to coverable lines.

❗ Current head f2fabfe differs from pull request most recent head 08292ce. Consider uploading reports for the commit 08292ce to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2545      +/-   ##
==========================================
- Coverage   10.55%   10.54%   -0.01%     
==========================================
  Files        1268     1268              
  Lines       87612    87612              
  Branches    20938    20938              
==========================================
- Hits         9246     9242       -4     
- Misses      68503    68505       +2     
- Partials     9863     9865       +2     
Flag Coverage Δ
total 10.54% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 78.72% <0.00%> (-8.52%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I agree using linear interpolation instead of spline since you found there was not so much difference in their Hz as you said in TIER IV internal link.

Sorry but Horibe-san will try to use spline as he said here? so for now I dismissed my approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants