Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_map_launch): remove configs and move to autoware_launch #2538

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Dec 20, 2022

Signed-off-by: kminoda koji.minoda@tier4.jp

Description

Move config to autoware_launch.

Two PRs should be merged at the same time.

Related links

autowarefoundation/autoware_launch#66

Tests performed

Launch logging_simulator.launch.xml and verified that the lanelet and pointcloud maps are displayed on RViz.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Dec 20, 2022
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda marked this pull request as ready for review December 20, 2022 09:55
@kminoda kminoda requested review from mitsudome-r, RyuYamamoto and a team as code owners December 20, 2022 09:55
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 10.54% // Head: 10.54% // No change to project coverage 👍

Coverage data is based on head (f00908e) compared to base (ee9a389).
Patch has no changes to coverable lines.

❗ Current head f00908e differs from pull request most recent head 4a61758. Consider uploading reports for the commit 4a61758 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2538   +/-   ##
=======================================
  Coverage   10.54%   10.54%           
=======================================
  Files        1266     1266           
  Lines       87617    87617           
  Branches    20952    20952           
=======================================
  Hits         9242     9242           
  Misses      68512    68512           
  Partials     9863     9863           
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 10.54% <ø> (ø) Carriedforward from 226b760

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@takayuki5168 takayuki5168 merged commit 618746c into autowarefoundation:main Dec 21, 2022
@kminoda kminoda deleted the feat/map/add_component_launch_in_autoware_launch branch December 22, 2022 01:28
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Dec 22, 2022
…utowarefoundation#2538)

* feat(tier4_map_launch): remove configs and move to autoware_launch

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove config

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda added a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…utowarefoundation#2538)

* feat(tier4_map_launch): remove configs and move to autoware_launch

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove config

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants