-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_map_launch): remove configs and move to autoware_launch #2538
feat(tier4_map_launch): remove configs and move to autoware_launch #2538
Conversation
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Codecov ReportBase: 10.54% // Head: 10.54% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2538 +/- ##
=======================================
Coverage 10.54% 10.54%
=======================================
Files 1266 1266
Lines 87617 87617
Branches 20952 20952
=======================================
Hits 9242 9242
Misses 68512 68512
Partials 9863 9863
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
…utowarefoundation#2538) * feat(tier4_map_launch): remove configs and move to autoware_launch Signed-off-by: kminoda <koji.minoda@tier4.jp> * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove config Signed-off-by: kminoda <koji.minoda@tier4.jp> * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
…utowarefoundation#2538) * feat(tier4_map_launch): remove configs and move to autoware_launch Signed-off-by: kminoda <koji.minoda@tier4.jp> * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove config Signed-off-by: kminoda <koji.minoda@tier4.jp> * update readme Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda koji.minoda@tier4.jp
Description
Move config to autoware_launch.
Two PRs should be merged at the same time.
Related links
autowarefoundation/autoware_launch#66
Tests performed
Launch logging_simulator.launch.xml and verified that the lanelet and pointcloud maps are displayed on RViz.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.