Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operation_mode_transition_manager): add parameter about nearest search #2523

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Dec 19, 2022

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Description

Add parameters about nearest search to operation_mode_transition_manager.
The parameter values are the same as those used in other modules such as here.

Related links

Tests performed

I confimred that the operation_mode_transition_manager launched without errors.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…search

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested review from TakaHoribe and a team as code owners December 19, 2022 08:12
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 10.54% // Head: 10.53% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1eb00a9) compared to base (418d8e5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2523      +/-   ##
==========================================
- Coverage   10.54%   10.53%   -0.01%     
==========================================
  Files        1266     1266              
  Lines       87648    87703      +55     
  Branches    20937    20937              
==========================================
  Hits         9242     9242              
- Misses      68543    68598      +55     
  Partials     9863     9863              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.54% <0.00%> (ø) Carriedforward from 418d8e5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ol/operation_mode_transition_manager/src/state.cpp 0.00% <0.00%> (ø)
...ol/operation_mode_transition_manager/src/state.hpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit f8af70c into autowarefoundation:main Dec 19, 2022
@tkimura4 tkimura4 deleted the feat/operation_manager/add_nearest_search_param branch December 19, 2022 11:45
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…search (autowarefoundation#2523)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants