Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tier4_autoware_utils): add maintainers #2520

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 18, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

added @takayuki5168 and @purewater0901, who contribute to tier4_autoware_utils a lot, to maintainers of tier4_autoware_utils

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 18, 2022
@takayuki5168 takayuki5168 marked this pull request as ready for review December 18, 2022 09:36
@takayuki5168
Copy link
Contributor Author

@kenji-miyake @TakaHoribe Could you review this.

@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 11.31% // Head: 11.09% // Decreases project coverage by -0.21% ⚠️

Coverage data is based on head (26d14f3) compared to base (4a6990c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2520      +/-   ##
==========================================
- Coverage   11.31%   11.09%   -0.22%     
==========================================
  Files        1166     1215      +49     
  Lines       81989    88017    +6028     
  Branches    20937    22611    +1674     
==========================================
+ Hits         9273     9766     +493     
- Misses      62834    68131    +5297     
- Partials     9882    10120     +238     
Flag Coverage Δ *Carryforward flag
differential 12.30% <ø> (?)
total 11.31% <ø> (ø) Carriedforward from 4a6990c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/src/scene_module/avoidance/avoidance_utils.cpp 1.39% <0.00%> (-0.61%) ⬇️
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <0.00%> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp 0.00% <0.00%> (ø)
planning/static_centerline_optimizer/src/utils.cpp 0.00% <0.00%> (ø)
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
...ing/obstacle_avoidance_planner/src/utils/utils.cpp 0.00% <0.00%> (ø)
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 0.00% <0.00%> (ø)
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)
... and 92 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kenji-miyake kenji-miyake changed the title owner(tier4_autoware_utils): add maintainers chore(tier4_autoware_utils): add maintainers Dec 18, 2022
@takayuki5168 takayuki5168 merged commit 418d8e5 into autowarefoundation:main Dec 19, 2022
@takayuki5168 takayuki5168 deleted the owner/add-tier4-autoware-utils-maintainer branch December 19, 2022 01:14
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
owner(tier4_autoware_utils): add maintainers

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants