Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): remove unnecessary parameters #2516

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Dec 16, 2022

Description

Remove unnecessary drivable area parameters. These parameters are no longer used due to the recent change of the drivable area format.

Related PR

Drivable Area Change

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Dec 16, 2022
@purewater0901 purewater0901 changed the title Feat/remove unnecessary parameters feat(behavior_path_planner): remove unnecessary parameters Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 10.57% // Head: 10.55% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (d256156) compared to base (c7d3b7d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2516      +/-   ##
==========================================
- Coverage   10.57%   10.55%   -0.03%     
==========================================
  Files        1265     1265              
  Lines       87439    87625     +186     
  Branches    20942    21076     +134     
==========================================
+ Hits         9244     9245       +1     
- Misses      68333    68489     +156     
- Partials     9862     9891      +29     
Flag Coverage Δ *Carryforward flag
differential 3.15% <ø> (?)
total 10.57% <ø> (ø) Carriedforward from c7d3b7d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 0.28% <ø> (+0.10%) ⬆️
planning/static_centerline_optimizer/src/utils.cpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 5f49fd7 into autowarefoundation:main Dec 18, 2022
@purewater0901 purewater0901 deleted the feat/remove-unnecessary-parameters branch December 18, 2022 07:46
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…oundation#2516)

* feat(behavior_path_planner): remove unnecessary parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

* remove from static_centerline_optimizer

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants