Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruies_planner): improve pid_based cruise planner #2507

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 15, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

  • improved PID-based adaptive cruise algorithm and tuned parameters to realize that
    • the ego will decelerate enough when the front car decelerates.
    • the cut-in deceleration is not too large
    • the vehicle's velocity/acceleration is not jerky when cruise is stable (= the actual distance to the front car is almost the same as the ideal one)
  • changed idling_time (1.5 -> 2.0) to be less dangerous
  • set bicycle as cruise target since the bicycle is regarded as a vehicle according to the law.
  • added disable_stop_planning flag

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Dec 15, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Dec 15, 2022
@takayuki5168 takayuki5168 marked this pull request as ready for review December 15, 2022 04:31
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 10.56% // Head: 10.49% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (532ebb4) compared to base (469d892).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2507      +/-   ##
==========================================
- Coverage   10.56%   10.49%   -0.08%     
==========================================
  Files        1266     1268       +2     
  Lines       87738    88325     +587     
  Branches    20924    20924              
==========================================
  Hits         9266     9266              
- Misses      68597    69184     +587     
  Partials     9875     9875              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.56% <0.00%> (ø) Carriedforward from 469d892

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/obstacle_cruise_planner/common_structs.hpp 0.00% <ø> (ø)
...e_planner/include/obstacle_cruise_planner/node.hpp 0.00% <ø> (ø)
...r/pid_based_planner/cruise_planning_debug_info.hpp 0.00% <0.00%> (ø)
...se_planner/pid_based_planner/pid_based_planner.hpp 0.00% <0.00%> (ø)
...lude/obstacle_cruise_planner/planner_interface.hpp 0.00% <0.00%> (ø)
...stacle_cruise_planner/stop_planning_debug_info.hpp 0.00% <0.00%> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
...lanner/src/pid_based_planner/pid_based_planner.cpp 0.00% <0.00%> (ø)
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit 9ecc3a2 into autowarefoundation:main Dec 18, 2022
@takayuki5168 takayuki5168 deleted the feat/improve-pid-based-cruise branch December 18, 2022 04:23
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…warefoundation#2507)

* feat(obstacle_cruies_planner): improve pid_based cruise planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update param in tier4_planning_launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants