Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add component launch in autoware launch #2479

Closed
wants to merge 18 commits into from
Closed

feat: add component launch in autoware launch #2479

wants to merge 18 commits into from

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Dec 8, 2022 •
edited
Loading

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kminoda and others added 6 commits December 7, 2022 08:59
@kminoda
proposal C
b702cea
@kminoda
remove config
618f90b 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
minor fix
f20ecbb 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
1523f37
@kminoda
update readme
22f0446 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
first commit
0f4943e 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Dec 8, 2022
pre-commit-ci bot and others added 3 commits December 8, 2022 12:21
@kminoda kminoda mentioned this pull request Dec 10, 2022
Closed
6 tasks
@kminoda
update system and map launch files
430a408 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
update
4f762a4 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda changed the title feat(tier4_localization_launch): add component launch in autoware launch feat: add component launch in autoware launch Dec 19, 2022
@kminoda kminoda mentioned this pull request Dec 19, 2022
Closed
7 tasks
kminoda and others added 5 commits December 20, 2022 09:47
@kminoda
removed unnecessary config
6578f47 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
0377c18
@kminoda
Merge remote-tracking branch 'origin' into feat/add_component_launch_…
f004b4e 
…in_autoware_launch
@kminoda
listed all args in component launch
d5815c0 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
update simulator.launch.xml
f5a2694 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda closed this Dec 21, 2022
@kminoda kminoda deleted the feat/add_component_launch_in_autoware_launch branch December 22, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ito-san ito-san Awaiting requested review from ito-san ito-san will be requested when the pull request is marked ready for review ito-san is a code owner

@TetsuKawa TetsuKawa Awaiting requested review from TetsuKawa TetsuKawa will be requested when the pull request is marked ready for review TetsuKawa is a code owner

@KeisukeShima KeisukeShima Awaiting requested review from KeisukeShima KeisukeShima will be requested when the pull request is marked ready for review KeisukeShima is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 will be requested when the pull request is marked ready for review taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe will be requested when the pull request is marked ready for review TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 will be requested when the pull request is marked ready for review takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 will be requested when the pull request is marked ready for review tkimura4 is a code owner

@miursh miursh Awaiting requested review from miursh miursh will be requested when the pull request is marked ready for review miursh is a code owner

@technolojin technolojin Awaiting requested review from technolojin technolojin will be requested when the pull request is marked ready for review technolojin is a code owner

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi will be requested when the pull request is marked ready for review YoshiRi is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito will be requested when the pull request is marked ready for review yukkysaito is a code owner

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 will be requested when the pull request is marked ready for review anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi will be requested when the pull request is marked ready for review KYabuuchi is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san will be requested when the pull request is marked ready for review Motsu-san is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto will be requested when the pull request is marked ready for review RyuYamamoto is a code owner

@SakodaShintaro SakodaShintaro Awaiting requested review from SakodaShintaro SakodaShintaro will be requested when the pull request is marked ready for review SakodaShintaro is a code owner

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4 TaikiYamada4 will be requested when the pull request is marked ready for review TaikiYamada4 is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo will be requested when the pull request is marked ready for review YamatoAndo is a code owner

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kminoda