Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(system_monitor): add maintainer #2420

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

ito-san
Copy link
Contributor

@ito-san ito-san commented Dec 1, 2022

Signed-off-by: ito-san fumihito.ito@tier4.jp

Description

Add maintainer of system_monitor and tier4_system_launch.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: ito-san <fumihito.ito@tier4.jp>
@ito-san ito-san requested review from a team and kenji-miyake as code owners December 1, 2022 05:20
@ito-san ito-san self-assigned this Dec 1, 2022
@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:system System design and integration. (auto-assigned) labels Dec 1, 2022
@ito-san ito-san removed the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Dec 1, 2022
@ito-san ito-san enabled auto-merge (squash) December 1, 2022 05:21
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 10.50% // Head: 10.59% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (1b7e247) compared to base (8bbc505).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2420      +/-   ##
==========================================
+ Coverage   10.50%   10.59%   +0.08%     
==========================================
  Files        1260     1255       -5     
  Lines       91665    86890    -4775     
  Branches    21121    20727     -394     
==========================================
- Hits         9629     9203     -426     
+ Misses      71980    67843    -4137     
+ Partials    10056     9844     -212     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.59% <0.00%> (+0.11%) ⬆️ Carriedforward from 03de605

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 0.19% <0.00%> (+<0.01%) ⬆️
...ssing/include/signal_processing/lowpass_filter.hpp 33.33% <0.00%> (-66.67%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
..._utils/include/grid_map_utils/polygon_iterator.hpp 50.00% <0.00%> (-25.00%) ⬇️
...or/include/planning_error_monitor/debug_marker.hpp 50.00% <0.00%> (-25.00%) ⬇️
...oware_auto_geometry/test/src/test_hull_pockets.cpp 45.65% <0.00%> (-10.60%) ⬇️
...autoware_auto_geometry/test/src/test_common_2d.cpp 42.85% <0.00%> (-10.48%) ⬇️
...eespace_planning_algorithms/abstract_algorithm.hpp 60.00% <0.00%> (-10.00%) ⬇️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 73.58% <0.00%> (-9.44%) ⬇️
...include/perception_utils/object_classification.hpp 60.00% <0.00%> (-8.75%) ⬇️
... and 655 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kenji-miyake kenji-miyake disabled auto-merge December 1, 2022 07:18
@kenji-miyake kenji-miyake merged commit 17f1b95 into autowarefoundation:main Dec 1, 2022
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
Signed-off-by: ito-san <fumihito.ito@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
Signed-off-by: ito-san <fumihito.ito@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants