Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tensorrt_yolox): add ignorefile #2419

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Dec 1, 2022

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

  • add ignore file

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota requested review from wep21, manato and a team as code owners December 1, 2022 03:57
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota enabled auto-merge (squash) December 1, 2022 04:05
Copy link
Contributor

@manato manato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 10.59% // Head: 10.59% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e0fc527) compared to base (03de605).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2419      +/-   ##
==========================================
- Coverage   10.59%   10.59%   -0.01%     
==========================================
  Files        1255     1255              
  Lines       86842    86851       +9     
  Branches    20727    20727              
==========================================
  Hits         9203     9203              
- Misses      67795    67804       +9     
  Partials     9844     9844              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.59% <ø> (ø) Carriedforward from 03de605

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
perception/tensorrt_yolox/src/tensorrt_yolox.cpp 0.00% <0.00%> (ø)
...ception/tensorrt_yolox/src/tensorrt_yolox_node.cpp 0.00% <0.00%> (ø)
...rt_yolox/src/yolox_single_image_inference_node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota merged commit a02830a into autowarefoundation:main Dec 1, 2022
tzhong518 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 9, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota deleted the chore/add-ignore-file branch December 12, 2022 06:50
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants