Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip building tensorrt yolox packages if cuda is not found #2412

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Nov 30, 2022

Signed-off-by: Daisuke Nishimatsu border_goldenmarket@yahoo.co.jp

Description

skip building cuda_utils, tensorrt_common, tensorrt_yolox if cuda is not found.

Related:

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 requested a review from manato November 30, 2022 14:42
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Nov 30, 2022
@wep21 wep21 requested a review from kenji-miyake November 30, 2022 14:42
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 10.47% // Head: 10.42% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (baee101) compared to base (a85643f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2412      +/-   ##
==========================================
- Coverage   10.47%   10.42%   -0.05%     
==========================================
  Files        1248     1254       +6     
  Lines       91319    91736     +417     
  Branches    21044    21044              
==========================================
  Hits         9565     9565              
- Misses      71567    71984     +417     
  Partials    10187    10187              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.45% <ø> (ø) Carriedforward from 146e3fe

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...common/include/tensorrt_common/tensorrt_common.hpp 0.00% <0.00%> (ø)
common/tensorrt_common/src/tensorrt_common.cpp 0.00% <0.00%> (ø)
...rt_yolox/include/tensorrt_yolox/tensorrt_yolox.hpp 0.00% <0.00%> (ø)
perception/tensorrt_yolox/src/tensorrt_yolox.cpp 0.00% <0.00%> (ø)
...ception/tensorrt_yolox/src/tensorrt_yolox_node.cpp 0.00% <0.00%> (ø)
...rt_yolox/src/yolox_single_image_inference_node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kenji-miyake
Copy link
Contributor

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wep21 wep21 merged commit 96c9b48 into main Dec 1, 2022
@wep21 wep21 deleted the skip-build-tensorrt-yolox branch December 1, 2022 01:28
tzhong518 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 9, 2022
…warefoundation#2412)

* fix: skip building tensorrt yolox packages if cuda is not found

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix typo

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…warefoundation#2412)

* fix: skip building tensorrt yolox packages if cuda is not found

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix typo

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…warefoundation#2412)

* fix: skip building tensorrt yolox packages if cuda is not found

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix typo

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants