fix(ekf_localizer): lowpass filter initialization #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YamatoAndo
approved these changes
Nov 30, 2022
Codecov ReportBase: 10.52% // Head: 10.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2402 +/- ##
==========================================
- Coverage 10.52% 10.51% -0.01%
==========================================
Files 1247 1247
Lines 90925 90938 +13
Branches 21033 21038 +5
==========================================
Hits 9566 9566
- Misses 71173 71186 +13
Partials 10186 10186
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…#2402) * fix(ekf_localizer): lowpass filter initialization Signed-off-by: kminoda <koji.minoda@tier4.jp> * ci(pre-commit): autofix * debug Signed-off-by: kminoda <koji.minoda@tier4.jp> * ci(pre-commit): autofix Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda
added a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…#2402) * fix(ekf_localizer): lowpass filter initialization Signed-off-by: kminoda <koji.minoda@tier4.jp> * ci(pre-commit): autofix * debug Signed-off-by: kminoda <koji.minoda@tier4.jp> * ci(pre-commit): autofix Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kminoda koji.minoda@tier4.jp
Description
Initialize 1D_filter (for z, roll, and pitch) in initial pose callback function.
This would make a difference when performing pose estimation for two or more times.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.