Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operation_mode_transition_manager): add guard to invalid parameter #2388

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Nov 28, 2022

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Description

In operation_mode_transition_manager node, if transition_timeout is less than or equal to stable_check.duration, Autoware never succeeds to engage.
I added a function to forcibly rewrite transition_timeout parameter if such a parameter is set,

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested review from TakaHoribe and a team as code owners November 28, 2022 09:08
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 10.48% // Head: 10.47% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (55f4bb7) compared to base (aca3d67).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2388      +/-   ##
==========================================
- Coverage   10.48%   10.47%   -0.01%     
==========================================
  Files        1248     1248              
  Lines       91225    91285      +60     
  Branches    21014    21014              
==========================================
  Hits         9565     9565              
- Misses      71473    71533      +60     
  Partials    10187    10187              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.46% <0.00%> (ø) Carriedforward from aca3d67

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...rol/operation_mode_transition_manager/src/node.cpp 0.00% <0.00%> (ø)
...ol/operation_mode_transition_manager/src/state.cpp 0.00% <0.00%> (ø)
...alization/gyro_odometer/src/gyro_odometer_core.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tkimura4 tkimura4 merged commit a7f20aa into autowarefoundation:main Feb 10, 2023
@tkimura4 tkimura4 deleted the feature/add_guard_to_operation_mode_parameter branch February 10, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants