-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_planning_rviz_plugin): add offset from baselink param #2384
feat(tier4_planning_rviz_plugin): add offset from baselink param #2384
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
08228b7
to
2b62c1f
Compare
Codecov ReportBase: 10.48% // Head: 10.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2384 +/- ##
==========================================
- Coverage 10.48% 10.47% -0.01%
==========================================
Files 1248 1248
Lines 91218 91271 +53
Branches 21012 21012
==========================================
Hits 9565 9565
- Misses 71466 71519 +53
Partials 10187 10187
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Why is this visualization necessary? |
@yukkysaito I update the docs for the purpose
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just memo. |
…owarefoundation#2384) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…owarefoundation#2384) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Description
Add param for offset_from_baselink in the footprint visualization.
The aim is to visualize the difference in footprint when following different coordinate systems for a trajectory.
This analysis is required in path planning, e.g. the obstacle_avoidance_planner has the same parameter that sets the offset length from baselink for the path optimization algorithm.
When the trajectory is followed in the baselink the footprint is shown as the yellow polygon, and vehicle center coodrinate makes the red one.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.