-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): update expansion function for drivable area #2320
feat(behavior_path_planner): update expansion function for drivable area #2320
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Internal Test Result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 10.48% // Head: 10.38% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2320 +/- ##
==========================================
- Coverage 10.48% 10.38% -0.11%
==========================================
Files 1249 1250 +1
Lines 90888 91927 +1039
Branches 20860 21569 +709
==========================================
+ Hits 9531 9548 +17
- Misses 71229 72163 +934
- Partials 10128 10216 +88
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…rea (autowarefoundation#2320) * fix(behavior_path_planner): delete unnecessary codes Signed-off-by: yutaka <purewater0901@gmail.com> * feat(behavior_path_planner): reorganize behavior path Signed-off-by: yutaka <purewater0901@gmail.com> * empty commit Signed-off-by: yutaka <purewater0901@gmail.com> * feat(behavior_path_planner): reorganize avoidance path Signed-off-by: yutaka <purewater0901@gmail.com> * feat(behavior_path_planner): update expand lanelet Signed-off-by: yutaka <purewater0901@gmail.com> * fix lane change Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
…rea (autowarefoundation#2320) * fix(behavior_path_planner): delete unnecessary codes Signed-off-by: yutaka <purewater0901@gmail.com> * feat(behavior_path_planner): reorganize behavior path Signed-off-by: yutaka <purewater0901@gmail.com> * empty commit Signed-off-by: yutaka <purewater0901@gmail.com> * feat(behavior_path_planner): reorganize avoidance path Signed-off-by: yutaka <purewater0901@gmail.com> * feat(behavior_path_planner): update expand lanelet Signed-off-by: yutaka <purewater0901@gmail.com> * fix lane change Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Description
Currently, the expansion function for drivable area is not correct. It expands lanelets that are not necessary to do so. For example, it expands the middle lanelet, and also expand left boundary line of the rightmost lanelet of the road. In this PR, I created a new data type called Drivable Lanes to put lanes in the right order(from the begging to the end). It also enables users to store the rightmost lanelet and leftmost lanelet.
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.