Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): update expansion function for drivable area #2320

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Nov 18, 2022

Description

Currently, the expansion function for drivable area is not correct. It expands lanelets that are not necessary to do so. For example, it expands the middle lanelet, and also expand left boundary line of the rightmost lanelet of the road. In this PR, I created a new data type called Drivable Lanes to put lanes in the right order(from the begging to the end). It also enables users to store the rightmost lanelet and leftmost lanelet.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 18, 2022
purewater0901 and others added 4 commits November 18, 2022 19:01
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901
Copy link
Contributor Author

Internal Test Result
822/825

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 10.48% // Head: 10.38% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (4cad3eb) compared to base (3c0b335).
Patch coverage: 4.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2320      +/-   ##
==========================================
- Coverage   10.48%   10.38%   -0.11%     
==========================================
  Files        1249     1250       +1     
  Lines       90888    91927    +1039     
  Branches    20860    21569     +709     
==========================================
+ Hits         9531     9548      +17     
- Misses      71229    72163     +934     
- Partials    10128    10216      +88     
Flag Coverage Δ *Carryforward flag
differential 3.23% <4.16%> (?)
total 10.46% <2.72%> (ø) Carriedforward from 3c0b335

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/include/behavior_path_planner/data_manager.hpp 0.00% <0.00%> (ø)
..._planner/scene_module/pull_out/pull_out_module.hpp 0.00% <ø> (ø)
...lanner/scene_module/pull_over/pull_over_module.hpp 0.00% <ø> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 26.31% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...path_planner/src/scene_module/lane_change/util.cpp 0.00% <0.00%> (ø)
...ne_module/lane_following/lane_following_module.cpp 0.00% <0.00%> (ø)
...r/src/scene_module/pull_out/geometric_pull_out.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit 9929e9c into autowarefoundation:main Nov 18, 2022
@purewater0901 purewater0901 deleted the feat/fix-drivable-extension branch November 18, 2022 10:52
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…rea (autowarefoundation#2320)

* fix(behavior_path_planner): delete unnecessary codes

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(behavior_path_planner): reorganize behavior path

Signed-off-by: yutaka <purewater0901@gmail.com>

* empty commit

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(behavior_path_planner): reorganize avoidance path

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(behavior_path_planner): update expand lanelet

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix lane change

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…rea (autowarefoundation#2320)

* fix(behavior_path_planner): delete unnecessary codes

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(behavior_path_planner): reorganize behavior path

Signed-off-by: yutaka <purewater0901@gmail.com>

* empty commit

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(behavior_path_planner): reorganize avoidance path

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(behavior_path_planner): update expand lanelet

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix lane change

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants