fix(tensorrt_yolo): multi gpu on component container #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
|
Hello, @wep21 Nithimatsu-san and, @yukkysaito Saito-san, Could you review this PR? Do you have any opinion or alternative solution? |
Codecov ReportBase: 10.55% // Head: 10.55% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2297 +/- ##
==========================================
- Coverage 10.55% 10.55% -0.01%
==========================================
Files 1256 1256
Lines 91029 91048 +19
Branches 20790 20790
==========================================
Hits 9611 9611
- Misses 71260 71279 +19
Partials 10158 10158
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xmfcx
reviewed
Nov 15, 2022
wep21
reviewed
Nov 16, 2022
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
Signed-off-by: Kaan Çolak <kaancolak95@gmail.com>
wep21
approved these changes
Nov 27, 2022
xmfcx
approved these changes
Nov 27, 2022
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…ion#2297) Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jan 6, 2023
…ion#2297) Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kaan Colak kcolak@leodrive.ai
When working with tensorrt_yolo on multiple GPU device without compostable node container everything works fine.
But when I use
tensorrt_ yoloas a component nodelet, ifgpu_deviceis set to another then0tensorrt_yologives seg fault.Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.