Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compare_map_segmentation): publish processing-time and cyclic-time debug messages #2247

Merged

Conversation

yukke42
Copy link
Contributor

@yukke42 yukke42 commented Nov 8, 2022

Signed-off-by: yukke42 yusuke.muramatsu@tier4.jp

Description

Move timer and publisher to publish the correct debug messages of processing_time_ms and cyclic_time_ms.

Screenshot from 2022-11-08 18-32-57

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…e debug messages

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 11.13% // Head: 11.11% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (8dd2063) compared to base (ed6b5c8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2247      +/-   ##
==========================================
- Coverage   11.13%   11.11%   -0.02%     
==========================================
  Files        1200     1200              
  Lines       86211    86263      +52     
  Branches    20802    20793       -9     
==========================================
- Hits         9596     9592       -4     
- Misses      66482    66544      +62     
+ Partials    10133    10127       -6     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.10% <0.00%> (-0.01%) ⬇️ Carriedforward from a3864c1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ion/src/voxel_based_compare_map_filter_nodelet.cpp 0.00% <0.00%> (ø)
...rajectory_follower/pid_longitudinal_controller.hpp 0.00% <0.00%> (-28.58%) ⬇️
...planning_evaluator/src/planning_evaluator_node.cpp 37.11% <0.00%> (-1.04%) ⬇️
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% <0.00%> (ø)
...ctory_follower/src/pid_longitudinal_controller.cpp 36.73% <0.00%> (+0.19%) ⬆️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 73.58% <0.00%> (+9.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukke42 yukke42 enabled auto-merge (squash) November 9, 2022 00:31
@yukke42 yukke42 merged commit ea8553e into autowarefoundation:main Nov 9, 2022
yukke42 added a commit to tier4/autoware.universe that referenced this pull request Dec 11, 2022
…e debug messages (autowarefoundation#2247)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…e debug messages (autowarefoundation#2247)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…e debug messages (autowarefoundation#2247)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants