-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_autoware_utils): add quaternion operation #2244
feat(tier4_autoware_utils): add quaternion operation #2244
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
This PR needs to be merged before #2231 since control_performance_analysis uses this PR's functions. |
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM anyway.
This is ported from motion_common, which was used in the autoware.auto
Codecov ReportBase: 10.88% // Head: 11.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2244 +/- ##
==========================================
+ Coverage 10.88% 11.45% +0.57%
==========================================
Files 1179 1198 +19
Lines 84935 87186 +2251
Branches 20043 21353 +1310
==========================================
+ Hits 9242 9984 +742
- Misses 65931 66968 +1037
- Partials 9762 10234 +472
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ion#2244) * fet(tier4_autoware_utils): add quaternion operation Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix file name Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…ion#2244) * fet(tier4_autoware_utils): add quaternion operation Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix file name Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
motion_common is autoware.auto's unique implementation, where dependency from other packages will be removed soon. #2229
In autoware.universe, we have other utils packages that are tier4_autoware_utils/motion_utils.
Some control packages depend on motion_common's implementation, which I copied them to tier4_autoware_utils in this PR.
autoware.universe/common/motion_common/src/motion_common/motion_common.cpp
Lines 227 to 252 in 4f6c3d4
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.