fix(behavior_velocity_planner): int/uint for path index #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
|
@soblin |
TakaHoribe
reviewed
Nov 7, 2022
| @@ -93,7 +93,8 @@ std::optional<std::pair<size_t, size_t>> findLaneIdInterval( | |||
| break; | |||
| } | |||
| } | |||
| start = std::max<size_t>(0, start - 1); // the idx of last point before the interval | |||
| start = static_cast<size_t>( | |||
| std::max<int>(0, static_cast<int>(start) - 1)); // the idx of last point before the interval | |||
There was a problem hiding this comment.
how about this? To get rid of many casting.
start = start > 0 ? start - 1 : 0;
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
TakaHoribe
approved these changes
Nov 7, 2022
Codecov ReportBase: 11.09% // Head: 11.09% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2221 +/- ##
=======================================
Coverage 11.09% 11.09%
=======================================
Files 1202 1202
Lines 86198 86198
Branches 20706 20707 +1
=======================================
Hits 9564 9564
Misses 66542 66542
Partials 10092 10092
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
3 tasks
7 tasks
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2022
…dation#2221) * fixed int/uint for path index Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * reflected comments Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…dation#2221) * fixed int/uint for path index Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * reflected comments Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
soblin
added a commit
to soblin/autoware.universe
that referenced
this pull request
Dec 22, 2022
…dation#2221) * fixed int/uint for path index Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * reflected comments Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
YoshiRi
pushed a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Jan 11, 2023
…dation#2221) * fixed int/uint for path index Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * reflected comments Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mamoru Sobue mamoru.sobue@tier4.jp
Description
Fixed overflow of uint.
Related links
#2190
Tests performed
Fixed error in scenario test
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.