refactor(ndt_scan_matcher): isolate align function into ndt_omp #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
|
This PR will be ready for review after tier4/ndt_omp#16 is merged. (The CI test would not pass until then) |
KYabuuchi
reviewed
Nov 4, 2022
KYabuuchi
reviewed
Nov 4, 2022
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Codecov ReportBase: 10.84% // Head: 10.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2199 +/- ##
==========================================
- Coverage 10.84% 10.83% -0.02%
==========================================
Files 1178 1178
Lines 84833 84916 +83
Branches 19987 19987
==========================================
Hits 9204 9204
- Misses 65894 65977 +83
Partials 9735 9735
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
KYabuuchi
reviewed
Nov 7, 2022
Signed-off-by: kminoda <koji.minoda@tier4.jp>
KYabuuchi
approved these changes
Nov 7, 2022
4 tasks
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…warefoundation#2199) * first commit Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove align and NdtResults from ndt_scan_matcher Signed-off-by: kminoda <koji.minoda@tier4.jp> * rename variable Signed-off-by: kminoda <koji.minoda@tier4.jp> * ci(pre-commit): autofix * use getResult() function instead of executeScanMatching() Signed-off-by: kminoda <koji.minoda@tier4.jp> * for (auto...) -> for (const auto &...) Signed-off-by: kminoda <koji.minoda@tier4.jp> * removed unnecessary output_cloud declaration Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi
pushed a commit
to YoshiRi/autoware.universe
that referenced
this pull request
Jan 11, 2023
…warefoundation#2199) * first commit Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove align and NdtResults from ndt_scan_matcher Signed-off-by: kminoda <koji.minoda@tier4.jp> * rename variable Signed-off-by: kminoda <koji.minoda@tier4.jp> * ci(pre-commit): autofix * use getResult() function instead of executeScanMatching() Signed-off-by: kminoda <koji.minoda@tier4.jp> * for (auto...) -> for (const auto &...) Signed-off-by: kminoda <koji.minoda@tier4.jp> * removed unnecessary output_cloud declaration Signed-off-by: kminoda <koji.minoda@tier4.jp> Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kminoda koji.minoda@tier4.jp
Description
I would like to isolate the align function in the current ndt_scan_matcher (and also the
NdtResultclass) tondt_omp.This PR should be merged at the same time as tier4/ndt_omp#16.
(side note: This PR may induce a build error due to the version mismatch between autoware.universe and ndt_omp, only when the newer universe used with the older ndt_omp)
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.