Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: interpolation (#791) #218

Merged
merged 3 commits into from
Jan 6, 2022
Merged

fix: interpolation (#791) #218

merged 3 commits into from
Jan 6, 2022

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Dec 23, 2021 •
edited by taikitanaka3
Loading

Related Issue(required)

Description(required)

Fix spline interpolation

Review Procedure(required)

Related PR(optional)

https://github.com/tier4/autoware.iv/pull/2412
tier4/AutowareArchitectureProposal.iv#791

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@tkimura4 tkimura4 changed the title ix: fix interpolation ix: fix interpolation (#791) Dec 23, 2021
@tkimura4 tkimura4 changed the title ix: fix interpolation (#791) fix: fix interpolation (#791) Dec 23, 2021
@taikitanaka3 taikitanaka3 changed the title fix: fix interpolation (#791) fix: interpolation (#791) Dec 23, 2021
@taikitanaka3
Copy link
Contributor

taikitanaka3 commented Dec 23, 2021 •
edited
Loading

@kenji-miyake
Do you know the reason why semantic pr failed?
The commit message which is cherry-picked is not " fix: ~" ?

@kenji-miyake
Copy link
Contributor

You need to fix the commit message as well if you have only one commit.

@kenji-miyake
Copy link
Contributor

This is the reason.
image

Please read https://github.com/amannn/action-semantic-pull-request#configuration.

          # When using "Squash and merge" on a PR with only one commit, GitHub
          # will suggest using that commit message instead of the PR title for the
          # merge commit, and it's easy to commit this by mistake. Enable this option
          # to also validate the commit message for one commit PRs.
          validateSingleCommit: true

@tkimura4
fix: interpolation (autowarefoundation#791)
dfa2304 
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
taikitanaka3
taikitanaka3 approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@tkimura4 tkimura4 enabled auto-merge (squash) January 6, 2022 02:39
@tkimura4 tkimura4 merged commit b0e4852 into autowarefoundation:tier4/proposal Jan 6, 2022
takayuki5168 added a commit that referenced this pull request Jan 8, 2022
@kyoichi-sugahara @taikitanaka3
@1222-takeshi @kenji-miyake @wep21 @takayuki5168 @tkimura4
feat(simple_planning_simulator): add delay model of velocity and stee…
5f09a5d 
…ring (#235)

* add delay steer vel in psim

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* change wz to steer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix param description

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify readme

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify cmake

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci: change file URL

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: order to create callback (#220)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* chore: remove unnecessary depends (#227)

* ci: add check-build-depends.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: simplify build_depends.repos

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: remove exec_depend

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: use register-autonomoustuff-repository

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: add setup tasks to other workflows

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci: update .yamllint.yaml (#229)

* ci: update .yamllint.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: fix for yamllint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: remove warning for compile error (#198)

* fix: fix compile error of pointcloud preprocessor

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for had map utils

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for behavior velocity planner

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for compare map segmentation

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for occupancy grid map outlier filter

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for detection by tracker

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: restore comment

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: set control_mode false before autoware engage (#232)

* fix: set control_mode false before autoware engage

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add input/engage remap in launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: library path (#225)

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: interpolation (#791) (#218)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add missing function definition in .cpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* set input and state for DELAY_STEER_VEL model

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: fix typo

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
@tkimura4 @taikitanaka3
fix: interpolation (autowarefoundation#791) (autowarefoundation#218)
c7c2f28 
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
@kyoichi-sugahara @taikitanaka3
@1222-takeshi @kenji-miyake @wep21 @takayuki5168 @tkimura4
feat(simple_planning_simulator): add delay model of velocity and stee…
3dccbeb 
…ring (autowarefoundation#235)

* add delay steer vel in psim

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* change wz to steer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix param description

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify readme

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify cmake

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci: change file URL

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: order to create callback (autowarefoundation#220)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* chore: remove unnecessary depends (autowarefoundation#227)

* ci: add check-build-depends.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: simplify build_depends.repos

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: remove exec_depend

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: use register-autonomoustuff-repository

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: add setup tasks to other workflows

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci: update .yamllint.yaml (autowarefoundation#229)

* ci: update .yamllint.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: fix for yamllint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: remove warning for compile error (autowarefoundation#198)

* fix: fix compile error of pointcloud preprocessor

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for had map utils

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for behavior velocity planner

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for compare map segmentation

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for occupancy grid map outlier filter

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for detection by tracker

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: restore comment

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: set control_mode false before autoware engage (autowarefoundation#232)

* fix: set control_mode false before autoware engage

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add input/engage remap in launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: library path (autowarefoundation#225)

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: interpolation (autowarefoundation#791) (autowarefoundation#218)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add missing function definition in .cpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* set input and state for DELAY_STEER_VEL model

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: fix typo

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
@tkimura4 @taikitanaka3
fix: interpolation (autowarefoundation#791) (autowarefoundation#218)
d9a6616 
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
@kyoichi-sugahara @taikitanaka3
@1222-takeshi @kenji-miyake @wep21 @takayuki5168 @tkimura4
feat(simple_planning_simulator): add delay model of velocity and stee…
5e0e938 
…ring (autowarefoundation#235)

* add delay steer vel in psim

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* change wz to steer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix param description

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify readme

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify cmake

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci: change file URL

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: order to create callback (autowarefoundation#220)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* chore: remove unnecessary depends (autowarefoundation#227)

* ci: add check-build-depends.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: simplify build_depends.repos

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: remove exec_depend

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: use register-autonomoustuff-repository

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: add setup tasks to other workflows

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci: update .yamllint.yaml (autowarefoundation#229)

* ci: update .yamllint.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: fix for yamllint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: remove warning for compile error (autowarefoundation#198)

* fix: fix compile error of pointcloud preprocessor

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for had map utils

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for behavior velocity planner

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for compare map segmentation

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for occupancy grid map outlier filter

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for detection by tracker

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: restore comment

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: set control_mode false before autoware engage (autowarefoundation#232)

* fix: set control_mode false before autoware engage

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add input/engage remap in launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: library path (autowarefoundation#225)

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: interpolation (autowarefoundation#791) (autowarefoundation#218)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add missing function definition in .cpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* set input and state for DELAY_STEER_VEL model

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: fix typo

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 deleted the 791-AAP branch February 9, 2022 03:41
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
@kenji-miyake
Fix PR template (autowarefoundation#218)
31e4486 
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Shin-kyoto added a commit to Shin-kyoto/autoware.universe that referenced this pull request Feb 15, 2023
@yn-mrse @Shin-kyoto
fix(elevation_map_loader): remove and create map bagfile if it cannot…
ec11dab 
… be loaded (backport autowarefoundation#1772) (autowarefoundation#218)

fix(elevation_map_loader): remove and create map bagfile if it cannot be loaded (autowarefoundation#1772)

* fix(elevation_map_loader): remove and create map bagfile if it cannot be loaded

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

* fix(elevation_map_loader): add dependencies

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

* fix(elevation_map_loader): use snake case for variable

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Co-authored-by: Shintaro Tomie <58775300+Shin-kyoto@users.noreply.github.com>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
@satoshi-ota
feat(behavior_path_planner): add param for new planner manager (autow…
3b33944 
…arefoundation#218)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
@kenji-miyake
Change CI docker images to setup-ros-docker (#218)
7a66d30 
* Change CI docker images to setup-ros-docker

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add DEBIAN_FRONTEND=noninteractive

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taikitanaka3 taikitanaka3 taikitanaka3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkimura4 @taikitanaka3 @kenji-miyake