Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ndt_omp): migrate a package into universe #2166

Closed
wants to merge 12 commits into from

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Oct 27, 2022

Signed-off-by: kminoda koji.minoda@tier4.jp

Description

Migrating ndt_omp package from https://github.com/tier4/ndt_omp into universe.

Since we are planning to make a radical change to this package (as well as ndt_scan_matcher), the package is no longer necessary to be a forked repository. So I would like to migrate the package in universe so that the modification on this package would be easier to handle.

Note:

  • I would like to make the modification from the original package as little as possible for easier reviewing, so the package is NOT modified except
    • an additional license description in Readme
    • removing apps
    • applying pre-commit
  • As a next step, I am planning to modify the CMakeLists.txt and packages.xml so that they will align with the other Autoware packages (e.g. including autoware_cmake).

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda self-assigned this Oct 27, 2022
@kminoda kminoda added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Oct 27, 2022
@kminoda kminoda changed the title feat(ndt_omp): add a package feat(ndt_omp): migrate a package into universe Oct 27, 2022
kminoda and others added 9 commits October 27, 2022 18:30
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda marked this pull request as ready for review October 28, 2022 02:18
@kminoda kminoda marked this pull request as draft October 28, 2022 02:19
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 10.82% // Head: 10.82% // No change to project coverage 👍

Coverage data is based on head (2ae8d02) compared to base (3eb3b64).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2166   +/-   ##
=======================================
  Coverage   10.82%   10.82%           
=======================================
  Files        1177     1177           
  Lines       84503    84503           
  Branches    19896    19896           
=======================================
  Hits         9149     9149           
  Misses      65800    65800           
  Partials     9554     9554           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.80% <ø> (ø) Carriedforward from 3eb3b64

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kminoda kminoda closed this Oct 28, 2022
@kminoda kminoda deleted the feat/add_ndt_omp_here branch November 30, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant