Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_control_rviz_plugin): add time stamp for control command #2154

Merged

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Oct 26, 2022

Description

add missing time stamp for plugin

This is found while testing acc_cmd to acc_current map calibrator

image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 10.78% // Head: 10.77% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5051818) compared to base (897794a).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
- Coverage   10.78%   10.77%   -0.01%     
==========================================
  Files        1186     1186              
  Lines       84842    84879      +37     
  Branches    19899    19899              
==========================================
  Hits         9149     9149              
- Misses      66002    66039      +37     
  Partials     9691     9691              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.76% <0.00%> (ø) Carriedforward from 897794a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ontrol_rviz_plugin/src/tools/manual_controller.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe self-requested a review October 26, 2022 10:39
@taikitanaka3 taikitanaka3 merged commit 03b6ce4 into autowarefoundation:main Oct 26, 2022
@taikitanaka3 taikitanaka3 deleted the fix/manual_controller_add_stamp branch October 26, 2022 10:51
taikitanaka3 added a commit to tier4/autoware.universe that referenced this pull request Nov 1, 2022
…utowarefoundation#2154)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…utowarefoundation#2154)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants