fix(ground segmentation): correct initial condition of ground grid #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Codecov ReportBase: 10.77% // Head: 10.76% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2117 +/- ##
==========================================
- Coverage 10.77% 10.76% -0.01%
==========================================
Files 1181 1181
Lines 84558 84625 +67
Branches 19819 19819
==========================================
Hits 9108 9108
- Misses 65830 65897 +67
Partials 9620 9620
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 20, 2022
…utowarefoundation#2117) fix: correct initial condition of ground grid Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
4 tasks
tkimura4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 20, 2022
…utowarefoundation#2117) (#158) fix: correct initial condition of ground grid Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Jan 16, 2023
…utowarefoundation#2117) (autowarefoundation#158) fix: correct initial condition of ground grid Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com>
badai-nguyen
added a commit
to badai-nguyen/autoware.universe
that referenced
this pull request
Feb 2, 2023
…utowarefoundation#2117) fix: correct initial condition of ground grid Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: badai-nguyen dai.nguyen@tier4.jp
Description
This PR to fix a refactoring bug at #1899
Make the result the same as before refactoring at 52a2b86
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.