Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_avoidance,obstacle_cruise): unify virtual wall marker #2091

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Oct 18, 2022

Description

  • unify virtual wall marker

this change will need autoware_launch rviz marker change

tier4/autoware_launch#518

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 10.41% // Head: 10.41% // No change to project coverage 👍

Coverage data is based on head (716fafb) compared to base (6428714).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2091   +/-   ##
=======================================
  Coverage   10.41%   10.41%           
=======================================
  Files        1173     1173           
  Lines       83678    83678           
  Branches    19587    19587           
=======================================
  Hits         8713     8713           
  Misses      65430    65430           
  Partials     9535     9535           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.39% <0.00%> (ø) Carriedforward from 6428714

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <0.00%> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@taikitanaka3
Copy link
Contributor Author

taikitanaka3 commented Oct 20, 2022

@takayuki5168
can you approve this, if this name is OK?
cc : @shmpwk @1222-takeshi

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3
Copy link
Contributor Author

@takayuki5168
Thank you. Please do tier4/autoware_launch#518 as well

@taikitanaka3 taikitanaka3 enabled auto-merge (squash) October 20, 2022 09:07
@taikitanaka3 taikitanaka3 merged commit f22ba93 into autowarefoundation:main Oct 20, 2022
@taikitanaka3 taikitanaka3 deleted the refactor/motion_planning_unfy_virtual_wall_marker branch October 20, 2022 09:16
ktro2828 added a commit to ktro2828/autoware.universe that referenced this pull request Oct 21, 2022
ktro2828 added a commit to ktro2828/autoware.universe that referenced this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants