fix(tier4_perception_launch): fix missing container argument #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
|
@yukkysaito Hello Saito-san, Could you review this PR? |
Signed-off-by: Kaan Colak <kcolak@leodrive.ai>
3 tasks
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Dec 16, 2022
…efoundation#2087) * fix(tier4_perception_launch): fix missing container argument Signed-off-by: Kaan Colak <kcolak@leodrive.ai> * fix(tier4_perception_launch): rm unused param Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Signed-off-by: Kaan Colak <kcolak@leodrive.ai> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments given in
perception.launch.xmland accepted inpointcloud_based_occupancy_grid_map.launch.pyare incompatible with each other. It is impossible to pass pointcloud_container as a parameter toprobabilistic_occupancy_grid_mappackage.Relevant parameters :
perception.launch.xml#L70
pointcloud_based_occupancy_grid_map.launch.py#L82
Signed-off-by: Kaan Colak kcolak@leodrive.ai
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.