-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(raw_vehicle_cmd_converter): extend unit tests for invalid maps #2081
test(raw_vehicle_cmd_converter): extend unit tests for invalid maps #2081
Conversation
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Codecov ReportBase: 10.36% // Head: 10.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2081 +/- ##
==========================================
+ Coverage 10.36% 10.38% +0.01%
==========================================
Files 1176 1176
Lines 84005 84021 +16
Branches 19563 19580 +17
==========================================
+ Hits 8708 8724 +16
+ Misses 65796 65791 -5
- Partials 9501 9506 +5
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…utowarefoundation#2081) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT maxime.clement@tier4.jp
Description
This PR adds tests for invalid maps in the
raw_vehicle_cmd_converter
.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.