Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(raw_vehicle_cmd_converter): extend unit tests for invalid maps #2081

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Oct 17, 2022

Signed-off-by: Maxime CLEMENT maxime.clement@tier4.jp

Description

This PR adds tests for invalid maps in the raw_vehicle_cmd_converter.

  • Map with only 1 column.
  • Map with inconsistent number of rows.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Oct 17, 2022
@maxime-clem maxime-clem self-assigned this Oct 17, 2022
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@taikitanaka3 taikitanaka3 enabled auto-merge (squash) October 17, 2022 06:27
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 10.36% // Head: 10.38% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (bc00176) compared to base (4a0b1c3).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2081      +/-   ##
==========================================
+ Coverage   10.36%   10.38%   +0.01%     
==========================================
  Files        1176     1176              
  Lines       84005    84021      +16     
  Branches    19563    19580      +17     
==========================================
+ Hits         8708     8724      +16     
+ Misses      65796    65791       -5     
- Partials     9501     9506       +5     
Flag Coverage Δ *Carryforward flag
differential 5.52% <33.33%> (?)
total 10.34% <60.00%> (ø) Carriedforward from 4a0b1c3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <0.00%> (ø)
...stacle_avoidance_planner/src/utils/debug_utils.cpp 0.00% <ø> (ø)
..._converter/test/test_raw_vehicle_cmd_converter.cpp 35.61% <66.66%> (+5.79%) ⬆️
...hicle/raw_vehicle_cmd_converter/src/csv_loader.cpp 70.58% <100.00%> (+20.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@taikitanaka3 taikitanaka3 merged commit fae9726 into autowarefoundation:main Oct 17, 2022
taikitanaka3 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 2, 2022
…utowarefoundation#2081)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem deleted the test-raw_vehicle_cmd_converter-invalid_maps branch May 29, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants