-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(raw_vehicle_cmd_converter): remove duplicates and add unit test #2077
refactor(raw_vehicle_cmd_converter): remove duplicates and add unit test #2077
Conversation
this will make pid implementation easiter to accel/brake Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Codecov ReportBase: 10.44% // Head: 10.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2077 +/- ##
==========================================
- Coverage 10.44% 10.41% -0.04%
==========================================
Files 1171 1177 +6
Lines 77152 84162 +7010
Branches 19144 19665 +521
==========================================
+ Hits 8061 8763 +702
- Misses 59973 65850 +5877
- Partials 9118 9549 +431
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
vehicle/raw_vehicle_cmd_converter/include/raw_vehicle_cmd_converter/pid.hpp
Show resolved
Hide resolved
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
vehicle/raw_vehicle_cmd_converter/include/raw_vehicle_cmd_converter/accel_map.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
vehicle/raw_vehicle_cmd_converter/include/raw_vehicle_cmd_converter/node.hpp
Show resolved
Hide resolved
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
TODO |
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
…est (autowarefoundation#2077) * refactor: error message * refactor: remove pid depends from steer converter this will make pid implementation easiter to accel/brake Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * refactor: add getter setter method Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * chore: add maintainer Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * refactor: unite steer converter to same class name Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * chore: revert fix commit Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * refactor: use const Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> * refactor: add const left Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> * style: spell check Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * style: spell check Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * style: update const with suggestion Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * style: to steer map Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * style: spell check Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.