Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(raw_vehicle_cmd_converter): remove duplicates and add unit test #2077

Merged

Conversation

taikitanaka3
Copy link
Contributor

Description

  • refactor change
100% tests passed, 0 tests failed out of 5

Label Time Summary:
copyright     =   2.17 sec*proc (1 test)
cppcheck      =   0.70 sec*proc (1 test)
gtest         =   0.15 sec*proc (1 test)
lint_cmake    =   0.40 sec*proc (1 test)
linter        =   4.92 sec*proc (4 tests)
xmllint       =   1.64 sec*proc (1 test)

Total Test time (real) =   5.08 sec
Finished <<< raw_vehicle_cmd_converter [5.44s]          

Summary: 1 package finished [6.10s]

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

this will make pid implementation easiter to accel/brake

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
@taikitanaka3 taikitanaka3 requested a review from mkuri October 15, 2022 11:06
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Base: 10.44% // Head: 10.41% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (a3a334d) compared to base (94c248b).
Patch coverage: 35.46% of modified lines in pull request are covered.

❗ Current head a3a334d differs from pull request most recent head f2eec00. Consider uploading reports for the commit f2eec00 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2077      +/-   ##
==========================================
- Coverage   10.44%   10.41%   -0.04%     
==========================================
  Files        1171     1177       +6     
  Lines       77152    84162    +7010     
  Branches    19144    19665     +521     
==========================================
+ Hits         8061     8763     +702     
- Misses      59973    65850    +5877     
- Partials     9118     9549     +431     
Flag Coverage Δ *Carryforward flag
differential 6.76% <30.35%> (?)
total 10.34% <32.43%> (-0.11%) ⬇️ Carriedforward from 465713e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nverter/include/raw_vehicle_cmd_converter/node.hpp 0.00% <ø> (ø)
...onverter/include/raw_vehicle_cmd_converter/pid.hpp 0.00% <0.00%> (ø)
vehicle/raw_vehicle_cmd_converter/src/node.cpp 0.00% <0.00%> (ø)
vehicle/raw_vehicle_cmd_converter/src/pid.cpp 0.00% <0.00%> (ø)
...ehicle/raw_vehicle_cmd_converter/src/brake_map.cpp 27.27% <27.77%> (+12.27%) ⬆️
..._converter/test/test_raw_vehicle_cmd_converter.cpp 31.91% <33.33%> (+2.09%) ⬆️
...ehicle/raw_vehicle_cmd_converter/src/accel_map.cpp 31.91% <35.29%> (+15.24%) ⬆️
...ehicle/raw_vehicle_cmd_converter/src/steer_map.cpp 47.05% <47.05%> (ø)
common/osqp_interface/src/osqp_interface.cpp 34.35% <75.00%> (+0.60%) ⬆️
...hicle/raw_vehicle_cmd_converter/src/csv_loader.cpp 74.00% <85.00%> (+30.66%) ⬆️
... and 767 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

taikitanaka3 and others added 4 commits October 16, 2022 01:24
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
taikitanaka3 and others added 2 commits October 17, 2022 15:09
@taikitanaka3 taikitanaka3 enabled auto-merge (squash) October 17, 2022 06:15
@taikitanaka3
Copy link
Contributor Author

TODO
rtemove ff_map_initialized_ and terminate when there is no ff map

@taikitanaka3 taikitanaka3 merged commit d5db3ac into autowarefoundation:main Oct 17, 2022
@taikitanaka3 taikitanaka3 deleted the refactor/raw_vehicle_cmd_converter branch October 17, 2022 07:47
taikitanaka3 added a commit to tier4/autoware.universe that referenced this pull request Dec 2, 2022
…est (autowarefoundation#2077)

* refactor: error message

* refactor: remove pid depends from steer converter

this will make pid implementation easiter to accel/brake

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* refactor: add getter setter method

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: add maintainer

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* refactor: unite steer converter to same class name

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: revert fix commit

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* refactor: use const

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* refactor: add const left

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* style: spell check

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* style: spell check

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* style: update const with suggestion

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* style: to steer map

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* style: spell check

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants