Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtc_manager_rviz_plugin): add_indivisual_exe #2021

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Oct 5, 2022

Signed-off-by: tanaka3 ttatcoder@outlook.jp

Description

add individual execution for RTC modules

Related links

resolve #2010
[tier4 INTERNAL LINK]

Tests performed

by psim

2022-10-05-14-00-37.mp4

Notes for reviewers

this PR can be tested by psim

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 10.38% // Head: 10.37% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (97a1282) compared to base (ee4f381).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2021      +/-   ##
==========================================
- Coverage   10.38%   10.37%   -0.02%     
==========================================
  Files        1163     1163              
  Lines       82840    82965     +125     
  Branches    19287    19287              
==========================================
  Hits         8604     8604              
- Misses      64968    65093     +125     
  Partials     9268     9268              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.36% <0.00%> (ø) Carriedforward from ee4f381

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp 0.00% <0.00%> (ø)
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.hpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@taikitanaka3
Copy link
Contributor Author

@rej55
can you review this PR?

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 merged commit 5af5126 into autowarefoundation:main Oct 6, 2022
@rej55 rej55 deleted the feature/rtc_manager_panel_add_indivisual_approval branch October 6, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTC CooperateCommand is not manageable
2 participants