Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtc_reaplyer): add rtc_replayer #1993

Merged
merged 7 commits into from
Oct 6, 2022

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Sep 30, 2022

Description

Currently there is no way to replay rtc commands because CooperateCommands is service, therefore debugging is almost impossible.To solve this this PR makes rtc command replayer from rosbag topic rtc status.

Related links

'FOO COMPANY INTERNAL LINK'

Tests performed

by psim using foa

  • preparation
    if you use psim record as below
    ros2 bag record topic /api/external/get/rtc_status
    or if you use loigsim use your rosbag.

  • launch Psim or LogsimWithoutPlainning
    launch simulator

  • play bag with remapping
    remap /api/external/get/rtc_status to /debug/rtc_status
    ros2 bag play --remap /api/external/get/rtc_status:=/debug/rtc_status

  • launch replayer
    ros2 launch rtc_replayer rtc_replayer.launch.xml

experiment-2022-09-30_19.00.34.mp4

Notes for reviewers

thsi package is for developer

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3 taikitanaka3 requested a review from tkhmy September 30, 2022 06:30
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 10.34% // Head: 10.33% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1c14608) compared to base (6a6532b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1993      +/-   ##
==========================================
- Coverage   10.34%   10.33%   -0.01%     
==========================================
  Files        1162     1163       +1     
  Lines       82730    82781      +51     
  Branches    19271    19271              
==========================================
  Hits         8555     8555              
- Misses      64915    64966      +51     
  Partials     9260     9260              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.32% <ø> (ø) Carriedforward from d7399f2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/rtc_replayer/src/rtc_replayer_node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 marked this pull request as ready for review September 30, 2022 10:15
taikitanaka3 and others added 6 commits September 30, 2022 19:39
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 merged commit 84a66fe into autowarefoundation:main Oct 6, 2022
@rej55 rej55 deleted the feature/rtc_replayer branch October 6, 2022 08:51
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 15, 2022
* feat(rtc_replayer): add rtc_reaplayer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: small fix

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc: update

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: add debug print

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: fix

* fix: build fail

* style: spell check

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
taikitanaka3 added a commit to tier4/autoware.universe that referenced this pull request Nov 11, 2022
* feat(rtc_replayer): add rtc_reaplayer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: small fix

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc: update

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: add debug print

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: fix

* fix: build fail

* style: spell check

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
taikitanaka3 added a commit to tier4/autoware.universe that referenced this pull request Nov 14, 2022
* feat(rtc_replayer): add rtc_reaplayer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: small fix

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc: update

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: add debug print

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: fix

* fix: build fail

* style: spell check

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants