-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rtc_reaplyer): add rtc_replayer #1993
Conversation
Codecov ReportBase: 10.34% // Head: 10.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1993 +/- ##
==========================================
- Coverage 10.34% 10.33% -0.01%
==========================================
Files 1162 1163 +1
Lines 82730 82781 +51
Branches 19271 19271
==========================================
Hits 8555 8555
- Misses 64915 64966 +51
Partials 9260 9260
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
1dee9e5
to
08c5aef
Compare
planning/rtc_replayer/include/rtc_replayer/rtc_replayer_node.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(rtc_replayer): add rtc_reaplayer Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: small fix Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * doc: update Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * chore: add debug print Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: fix * fix: build fail * style: spell check Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
* feat(rtc_replayer): add rtc_reaplayer Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: small fix Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * doc: update Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * chore: add debug print Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: fix * fix: build fail * style: spell check Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
* feat(rtc_replayer): add rtc_reaplayer Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: small fix Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * doc: update Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> * chore: add debug print Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: fix * fix: build fail * style: spell check Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Description
Currently there is no way to replay rtc commands because CooperateCommands is service, therefore debugging is almost impossible.To solve this this PR makes rtc command replayer from rosbag topic rtc status.
Related links
'FOO COMPANY INTERNAL LINK'
Tests performed
by psim using foa
preparation
if you use psim record as below
ros2 bag record topic /api/external/get/rtc_status
or if you use loigsim use your rosbag.
launch Psim or LogsimWithoutPlainning
launch simulator
play bag with remapping
remap
/api/external/get/rtc_status
to/debug/rtc_status
ros2 bag play --remap /api/external/get/rtc_status:=/debug/rtc_status
launch replayer
ros2 launch rtc_replayer rtc_replayer.launch.xml
experiment-2022-09-30_19.00.34.mp4
Notes for reviewers
thsi package is for developer
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.