-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_cruise_planner): add terminal collision checker #1807
feat(obstacle_cruise_planner): add terminal collision checker #1807
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Open this PR after this PR gets approval form the reviewer. |
Codecov Report
@@ Coverage Diff @@
## main #1807 +/- ##
==========================================
- Coverage 10.47% 10.36% -0.12%
==========================================
Files 1218 1218
Lines 87462 87783 +321
Branches 20525 20793 +268
==========================================
- Hits 9165 9099 -66
- Misses 68825 69484 +659
+ Partials 9472 9200 -272
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: yutaka <purewater0901@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…refoundation#1807) * feat(motion_utils): add new search zero velocity Signed-off-by: yutaka <purewater0901@gmail.com> * change arguments Signed-off-by: yutaka <purewater0901@gmail.com> * feat(obstacle_cruise_planner): add terminal collision checker Signed-off-by: yutaka <purewater0901@gmail.com> * add parameters Signed-off-by: yutaka <purewater0901@gmail.com> * change parameters Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…refoundation#1807) * feat(motion_utils): add new search zero velocity Signed-off-by: yutaka <purewater0901@gmail.com> * change arguments Signed-off-by: yutaka <purewater0901@gmail.com> * feat(obstacle_cruise_planner): add terminal collision checker Signed-off-by: yutaka <purewater0901@gmail.com> * add parameters Signed-off-by: yutaka <purewater0901@gmail.com> * change parameters Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…refoundation#1807) * feat(motion_utils): add new search zero velocity Signed-off-by: yutaka <purewater0901@gmail.com> * change arguments Signed-off-by: yutaka <purewater0901@gmail.com> * feat(obstacle_cruise_planner): add terminal collision checker Signed-off-by: yutaka <purewater0901@gmail.com> * add parameters Signed-off-by: yutaka <purewater0901@gmail.com> * change parameters Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…refoundation#1807) * feat(motion_utils): add new search zero velocity Signed-off-by: yutaka <purewater0901@gmail.com> * change arguments Signed-off-by: yutaka <purewater0901@gmail.com> * feat(obstacle_cruise_planner): add terminal collision checker Signed-off-by: yutaka <purewater0901@gmail.com> * add parameters Signed-off-by: yutaka <purewater0901@gmail.com> * change parameters Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…refoundation#1807) * feat(motion_utils): add new search zero velocity Signed-off-by: yutaka <purewater0901@gmail.com> * change arguments Signed-off-by: yutaka <purewater0901@gmail.com> * feat(obstacle_cruise_planner): add terminal collision checker Signed-off-by: yutaka <purewater0901@gmail.com> * add parameters Signed-off-by: yutaka <purewater0901@gmail.com> * change parameters Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…refoundation#1807) * feat(motion_utils): add new search zero velocity Signed-off-by: yutaka <purewater0901@gmail.com> * change arguments Signed-off-by: yutaka <purewater0901@gmail.com> * feat(obstacle_cruise_planner): add terminal collision checker Signed-off-by: yutaka <purewater0901@gmail.com> * add parameters Signed-off-by: yutaka <purewater0901@gmail.com> * change parameters Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
…refoundation#1807) * feat(motion_utils): add new search zero velocity Signed-off-by: yutaka <purewater0901@gmail.com> * change arguments Signed-off-by: yutaka <purewater0901@gmail.com> * feat(obstacle_cruise_planner): add terminal collision checker Signed-off-by: yutaka <purewater0901@gmail.com> * add parameters Signed-off-by: yutaka <purewater0901@gmail.com> * change parameters Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
Description
Currently, obstacle cruise planner does not check the collision with obstacles at the end of the trajectory. In this PR, I extended the goal to enable it to check the collision even when it almost arrives at the goal.
![image](https://user-images.githubusercontent.com/43805014/189031302-56e6a3b6-4a3a-4d16-a8e3-062f89cb3478.png)
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.