Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): add terminal collision checker #1807

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Sep 8, 2022

Description

Currently, obstacle cruise planner does not check the collision with obstacles at the end of the trajectory. In this PR, I extended the goal to enable it to check the collision even when it almost arrives at the goal.
image

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901 and others added 2 commits September 8, 2022 13:03
Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901
Copy link
Contributor Author

@purewater0901
Copy link
Contributor Author

Open this PR after this PR gets approval form the reviewer.

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1807 (adcc87f) into main (d428887) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1807      +/-   ##
==========================================
- Coverage   10.47%   10.36%   -0.12%     
==========================================
  Files        1218     1218              
  Lines       87462    87783     +321     
  Branches    20525    20793     +268     
==========================================
- Hits         9165     9099      -66     
- Misses      68825    69484     +659     
+ Partials     9472     9200     -272     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.38% <0.00%> (-0.08%) ⬇️ Carriedforward from d9cd466

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e_planner/include/obstacle_cruise_planner/node.hpp 0.00% <ø> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 73.58% <0.00%> (-9.44%) ⬇️
control/trajectory_follower/src/interpolate.cpp 73.33% <0.00%> (-2.23%) ⬇️
...trajectory_follower/src/mpc_lateral_controller.cpp 34.31% <0.00%> (-1.31%) ⬇️
control/trajectory_follower/test/test_mpc.cpp 55.68% <0.00%> (-1.14%) ⬇️
...ctory_follower/src/pid_longitudinal_controller.cpp 38.49% <0.00%> (-1.12%) ⬇️
...tion_utils/test/src/trajectory/test_trajectory.cpp 25.62% <0.00%> (-0.64%) ⬇️
control/trajectory_follower/src/mpc.cpp 48.01% <0.00%> (-0.12%) ⬇️
... and 100 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 marked this pull request as ready for review September 8, 2022 14:38
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 8b00706 into autowarefoundation:main Sep 9, 2022
@purewater0901 purewater0901 deleted the feat/check-goal-collision branch September 9, 2022 02:19
voltonomous pushed a commit to vautonomous/autoware.universe that referenced this pull request Sep 11, 2022
…refoundation#1807)

* feat(motion_utils): add new search zero velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* change arguments

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(obstacle_cruise_planner): add terminal collision checker

Signed-off-by: yutaka <purewater0901@gmail.com>

* add parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

* change parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…refoundation#1807)

* feat(motion_utils): add new search zero velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* change arguments

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(obstacle_cruise_planner): add terminal collision checker

Signed-off-by: yutaka <purewater0901@gmail.com>

* add parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

* change parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…refoundation#1807)

* feat(motion_utils): add new search zero velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* change arguments

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(obstacle_cruise_planner): add terminal collision checker

Signed-off-by: yutaka <purewater0901@gmail.com>

* add parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

* change parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…refoundation#1807)

* feat(motion_utils): add new search zero velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* change arguments

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(obstacle_cruise_planner): add terminal collision checker

Signed-off-by: yutaka <purewater0901@gmail.com>

* add parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

* change parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2022
…refoundation#1807)

* feat(motion_utils): add new search zero velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* change arguments

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(obstacle_cruise_planner): add terminal collision checker

Signed-off-by: yutaka <purewater0901@gmail.com>

* add parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

* change parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2022
…refoundation#1807)

* feat(motion_utils): add new search zero velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* change arguments

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(obstacle_cruise_planner): add terminal collision checker

Signed-off-by: yutaka <purewater0901@gmail.com>

* add parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

* change parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…refoundation#1807)

* feat(motion_utils): add new search zero velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* change arguments

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(obstacle_cruise_planner): add terminal collision checker

Signed-off-by: yutaka <purewater0901@gmail.com>

* add parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

* change parameters

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants