Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior velocity): lighten topic #1806

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Sep 8, 2022

Description

lighten behavior velocity debug topics

ref:

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
@taikitanaka3 taikitanaka3 marked this pull request as ready for review September 8, 2022 02:24
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1806 (41e43e4) into main (c0f3507) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1806   +/-   ##
=======================================
  Coverage   10.40%   10.40%           
=======================================
  Files        1218     1218           
  Lines       87550    87550           
  Branches    20511    20511           
=======================================
  Hits         9109     9109           
  Misses      68981    68981           
  Partials     9460     9460           
Flag Coverage Δ *Carryforward flag
differential 4.23% <0.00%> (?)
total 10.38% <0.00%> (ø) Carriedforward from d05ac54

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/include/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.42% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shmpwk
Copy link
Contributor

shmpwk commented Sep 8, 2022

Sorry but I cannot determine if this change is valid when the subscription of topic rate is slow or irregular.

@taikitanaka3
Copy link
Contributor Author

taikitanaka3 commented Sep 8, 2022

@shmpwk
most of topics in other nodes queue size is 1 , but this behavior velocity's debug markers queue size 20 can cause stuck.

Sorry but I cannot determine if this change is valid when the subscription of topic rate is slow or irregular.

yes there is no best way to determine if this change is valid or not.

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit 79cb56f into autowarefoundation:main Sep 9, 2022
@taikitanaka3 taikitanaka3 deleted the feature/lighten_behavior_velocity_topic branch September 9, 2022 02:53
voltonomous pushed a commit to vautonomous/autoware.universe that referenced this pull request Sep 11, 2022
* feat(behavior velocity): lighten topic

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: add queue size of virtual wall for visualization

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
* feat(behavior velocity): lighten topic

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: add queue size of virtual wall for visualization

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
* feat(behavior velocity): lighten topic

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: add queue size of virtual wall for visualization

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
* feat(behavior velocity): lighten topic

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: add queue size of virtual wall for visualization

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
* feat(behavior velocity): lighten topic

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

* chore: add queue size of virtual wall for visualization

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants