Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lidar_centerpoint): yaw norm filter (cherrypicked) #1800

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Sep 7, 2022

Description

Added a filter to the centerpoint estimations to ignore detections that have a yaw angle norm below a certain threshold.

Centerpoint rather than estimate the rotation directly, estimates the cosine and sine of the angle.
As such the norm of the cos/sin pair should be unitary, but since the inference does not enforce this property, it may not hold.
Empirically, in those cases where the property does not hold, there is a high chance that the detection is wrong, so we filter them out.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 self-assigned this Sep 7, 2022
…norm_filter_cherrypicked

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 requested a review from yukke42 September 7, 2022 02:37
@knzo25
Copy link
Contributor Author

knzo25 commented Sep 7, 2022

@yukke42
Sorry, I did not know the signing requirement for the commits, and since I had done some merges, it was difficult to perform the necessary rebases. Instead, I just cherrypicked my commits (and signed them), and resubmitted the PR.

Old PR: #1728

@knzo25 knzo25 marked this pull request as ready for review September 7, 2022 02:38
@knzo25 knzo25 closed this Sep 7, 2022
@knzo25 knzo25 deleted the feature/centerpoint_yaw_norm_filter_cherrypicked branch September 7, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant