Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bag_time_manager_rviz_plugin): add bag time manager rviz plugin #1776

Merged
merged 6 commits into from
Sep 5, 2022
Merged

feat(bag_time_manager_rviz_plugin): add bag time manager rviz plugin #1776

merged 6 commits into from
Sep 5, 2022

Conversation

taikitanaka3
Copy link
Contributor

Description

  • add rosbag time manager rviz plugin
2022-09-05-11-50-20.mp4

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3
feat(bag_timemanager): add bag time manager rviz plugin
f1ce7c8 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 force-pushed the feat/add_bag_time_manager_rviz_plugin branch from cf22d19 to f1ce7c8 Compare September 5, 2022 03:07
@taikitanaka3 taikitanaka3 marked this pull request as ready for review September 5, 2022 03:07
@taikitanaka3
fix: fix change
38b5085 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@codecov
Copy link

codecov bot commented Sep 5, 2022 •
edited
Loading

Codecov Report

Merging #1776 (a42a173) into main (2f379a6) will decrease coverage by 0.43%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             main   #1776      +/-   ##
=========================================
- Coverage   10.35%   9.92%   -0.44%     
=========================================
  Files        1218    1213       -5     
  Lines       87375   78296    -9079     
  Branches    20224   18503    -1721     
=========================================
- Hits         9051    7768    -1283     
+ Misses      68874   61658    -7216     
+ Partials     9450    8870     -580
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.92% <ø> (-0.42%) ⬇️ Carriedforward from 2d00cb4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...manager_rviz_plugin/src/bag_time_manager_panel.cpp 0.00% <0.00%> (ø)
system/default_ad_api/src/interface.cpp 0.00% <0.00%> (-71.43%) ⬇️
...c/autoware_ad_api_msgs/msg/route__type_support.cpp 0.00% <0.00%> (-66.67%) ⬇️
...oware_ad_api_msgs/msg/route_data__type_support.cpp 0.00% <0.00%> (-66.67%) ⬇️
...ware_ad_api_msgs/msg/route_state__type_support.cpp 0.00% <0.00%> (-66.67%) ⬇️
...re_ad_api_msgs/msg/route_segment__type_support.cpp 0.00% <0.00%> (-66.67%) ⬇️
..._ad_api_msgs/msg/response_status__type_support.cpp 0.00% <0.00%> (-66.67%) ⬇️
..._ad_api_msgs/msg/route_primitive__type_support.cpp 0.00% <0.00%> (-66.67%) ⬇️
...ng_simulator/vehicle_model/sim_model_interface.hpp 0.00% <0.00%> (-66.67%) ⬇️
...ocalization_initialization_state__type_support.cpp 0.00% <0.00%> (-66.67%) ⬇️
... and 811 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taikitanaka3 taikitanaka3 enabled auto-merge (squash) September 5, 2022 03:19
@taikitanaka3
chore: add more description
a4f5292 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3
doc: update indent
2d00cb4 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
shmpwk
shmpwk approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It works perfect!

@taikitanaka3
style: fix pre-commit
cecc32d 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 added the type:documentation Creating or refining documentation. (auto-assigned) label Sep 5, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-1776/
Modified URLs:

@taikitanaka3
style: fix style doc
a42a173 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@shmpwk shmpwk self-requested a review September 5, 2022 06:08
@taikitanaka3 taikitanaka3 merged commit ce644b6 into autowarefoundation:main Sep 5, 2022
@taikitanaka3 taikitanaka3 deleted the feat/add_bag_time_manager_rviz_plugin branch September 5, 2022 06:14
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Sep 6, 2022
Merged
taikitanaka3 referenced this pull request in tier4/autoware.universe Sep 6, 2022
@taikitanaka3
feat(bag_time_manager_rviz_plugin): add bag time manager rviz plugin (#…
dccadc4 
…1776)

* feat(bag_timemanager): add bag time manager rviz plugin

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: fix change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 mentioned this pull request Sep 6, 2022
Merged
4 tasks
tkimura4 referenced this pull request in tier4/autoware.universe Sep 6, 2022
@taikitanaka3
feat(bag time manager): add to beta v0.5.2 (#108)
7ffc17b 
feat(bag_time_manager_rviz_plugin): add bag time manager rviz plugin (#1776)

* feat(bag_timemanager): add bag time manager rviz plugin

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: fix change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@taikitanaka3 @boyali
feat(bag_time_manager_rviz_plugin): add bag time manager rviz plugin (t…
6f8aee0 
…ier4#1776)

* feat(bag_timemanager): add bag time manager rviz plugin

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: fix change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@taikitanaka3 @boyali
feat(bag_time_manager_rviz_plugin): add bag time manager rviz plugin (t…
343cfe9 
…ier4#1776)

* feat(bag_timemanager): add bag time manager rviz plugin

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: fix change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@taikitanaka3 @boyali
feat(bag_time_manager_rviz_plugin): add bag time manager rviz plugin (t…
4df9f60 
…ier4#1776)

* feat(bag_timemanager): add bag time manager rviz plugin

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: fix change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@taikitanaka3 @boyali
feat(bag_time_manager_rviz_plugin): add bag time manager rviz plugin (t…
38d7a24 
…ier4#1776)

* feat(bag_timemanager): add bag time manager rviz plugin

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: fix change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
mitsudome-r pushed a commit to mitsudome-r/autoware.universe that referenced this pull request Jan 24, 2025
@youtalk @actions-user
chore(sync-files.yaml): not synchronize github-release.yaml (autowa…
1122841 
…refoundation#1776)

not sync github-release

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
mitsudome-r pushed a commit to mitsudome-r/autoware.universe that referenced this pull request Jan 24, 2025
@youtalk @actions-user
chore(sync-files.yaml): not synchronize github-release.yaml (autowa…
e94b09f 
…refoundation#1776)

not sync github-release

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Jan 24, 2025
@youtalk @actions-user
chore(sync-files.yaml): not synchronize github-release.yaml (autowa…
f3d4630 
…refoundation#1776)

not sync github-release

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Jan 27, 2025
@youtalk @actions-user
chore(sync-files.yaml): not synchronize github-release.yaml (autowa…
f96b625 
…refoundation#1776)

not sync github-release

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Jan 29, 2025
@youtalk @actions-user
chore(sync-files.yaml): not synchronize github-release.yaml (autowa…
f360763 
…refoundation#1776)

not sync github-release

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Jan 31, 2025
@youtalk @actions-user
chore(sync-files.yaml): not synchronize github-release.yaml (autowa…
36ce681 
…refoundation#1776)

not sync github-release

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmpwk shmpwk shmpwk approved these changes

@0x126 0x126 Awaiting requested review from 0x126

@tkimura4 tkimura4 Awaiting requested review from tkimura4

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

Assignees
No one assigned
Labels
type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taikitanaka3 @shmpwk