Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity): fix insertVelocity #1768

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Sep 2, 2022

Signed-off-by: tanaka3 ttatcoder@outlook.jp

Description

bug fix for insertVelcity util function in behavior velocity

  • this happen only insert path point is close to original

before
image

after
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3 taikitanaka3 marked this pull request as ready for review September 2, 2022 06:44
@taikitanaka3 taikitanaka3 changed the title fix(behavior_velocity): fix insertVecity fix(behavior_velocity): fix insertVelocity Sep 2, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 force-pushed the fix/behavior_velocity_insert_velocity branch from 4547366 to b5b0e92 Compare September 2, 2022 06:45
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1768 (b5b0e92) into main (6075e60) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1768   +/-   ##
=======================================
  Coverage   10.38%   10.38%           
=======================================
  Files        1212     1212           
  Lines       87407    87407           
  Branches    20282    20283    +1     
=======================================
  Hits         9080     9080           
  Misses      68846    68846           
  Partials     9481     9481           
Flag Coverage Δ *Carryforward flag
differential 4.57% <0.00%> (?)
total 10.37% <0.00%> (ø) Carriedforward from 6075e60

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...polation/include/interpolation/zero_order_hold.hpp 47.05% <ø> (ø)
...behavior_velocity_planner/src/utilization/util.cpp 12.45% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit 269b3bd into main Sep 2, 2022
@taikitanaka3 taikitanaka3 deleted the fix/behavior_velocity_insert_velocity branch September 2, 2022 07:37
taikitanaka3 referenced this pull request in tier4/autoware.universe Sep 2, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
taikitanaka3 referenced this pull request in tier4/autoware.universe Sep 2, 2022
…102)

fix(behavior_velocity): fix insertVelocity (#1768)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants