refactor(obstacle_stop_planner): update params name for readability #1720

satoshi-ota · 2022-08-29T09:20:35Z

Description

update params name for readability

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov · 2022-08-29T11:10:27Z

Codecov Report

Merging #1720 (532eb41) into main (57c4b1f) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1720      +/-   ##
==========================================
- Coverage   10.40%   10.36%   -0.05%     
==========================================
  Files        1221     1221              
  Lines       87508    87866     +358     
  Branches    20488    20488              
==========================================
  Hits         9108     9108              
- Misses      68924    69282     +358     
  Partials     9476     9476

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`10.39% <0.00%> (ø)`		Carriedforward from 57c4b1f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
planning/obstacle_stop_planner/src/node.cpp	`0.00% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-29T11:49:25Z

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-1720/
Modified URLs:

https://autowarefoundation.github.io/autoware.universe/pr-1720/planning/obstacle_stop_planner/

satoshi-ota · 2022-08-30T02:17:16Z

TODO: create PR for autoware_launch

satoshi-ota · 2022-08-30T08:38:28Z

TODO: create PR for autoware_launch

tier4/autoware_launch#458

h-ohta · 2022-08-31T09:56:02Z

@satoshi-ota Could you fix below?
https://github.com/autowarefoundation/autoware.universe/blob/main/launch/tier4_planning_launch/config/scenario_planning/lane_driving/motion_planning/obstacle_stop_planner/obstacle_stop_planner.param.yaml

satoshi-ota · 2022-09-01T04:40:43Z

@satoshi-ota Could you fix below? https://github.com/autowarefoundation/autoware.universe/blob/main/launch/tier4_planning_launch/config/scenario_planning/lane_driving/motion_planning/obstacle_stop_planner/obstacle_stop_planner.param.yaml

@h-ohta Fix in 4013048.

satoshi-ota · 2022-09-02T05:41:26Z

@h-ohta Evaluator test results:

Try 1: 782/823
Try 2: 783/823
Baseline 1: 785/823
Baseline 2: 788/823

I think there is no critical degration.

h-ohta · 2022-09-02T08:55:13Z

@satoshi-ota
The velocity_threshold_decel_complete are acceleration_threshold_decel_complete are not defined in param.yaml. Is this OK?

satoshi-ota · 2022-09-04T06:36:32Z

@satoshi-ota The velocity_threshold_decel_complete are acceleration_threshold_decel_complete are not defined in param.yaml. Is this OK?

@h-ohta I don't think it is necessary to add these params to the config file since they are parameters that are not frequently changed. (Additionaly, products using these parameters no longer exist.)

h-ohta · 2022-09-04T23:33:00Z

It is wasteful to define parameters which is rarely changed.
On the other hand, I guess all parameters should be defined in the param.yaml.
It is up to you.

LGTM to others.

satoshi-ota · 2022-09-04T23:36:48Z

It is wasteful to define parameters which is rarely changed. On the other hand, I guess all parameters should be defined in the param.yaml. It is up to you.

LGTM to others.

@h-ohta OK. I'll fix and add these params to config file.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

…rameter Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

satoshi-ota · 2022-09-06T00:49:04Z

@h-ohta add all params in config file.

h-ohta · 2022-09-06T06:35:02Z

I confimed.
https://github.com/autowarefoundation/autoware.universe/pull/1720/files#diff-cf194f76c0faede5c49f2b015508b61f6c5760233a0476e337292d8194d43590R48-R49
https://github.com/autowarefoundation/autoware.universe/pull/1720/files#diff-8644b541cf341399153ecba1cbb50a31899e02ae40f0acdf86cd07a331e402deR48-R49

…ier4#1720) * refactor(obstacle_stop_planner): update parameter name for readability Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(obstacle_stop_planner): update module documentation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(obstacle_stop_planner): update figure Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(obstacle_stop_planner): separate params by namespace Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(tier4_planning_launch): separate params by namespace Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(obstacle_stop_planner): remove default value from declare_parameter Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(obstacle_stop_planner): add params to config Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

…stability perf(lane_change): path stability and correctness

satoshi-ota added the type:documentation Creating or refining documentation. (auto-assigned) label Aug 29, 2022

satoshi-ota force-pushed the refactor/params-name-obstacle-stop branch from d36d1b9 to 3e329f3 Compare August 29, 2022 09:35

satoshi-ota requested review from TakaHoribe and h-ohta August 29, 2022 10:08

satoshi-ota force-pushed the refactor/params-name-obstacle-stop branch from df8e3b7 to 5a17ea3 Compare August 30, 2022 01:03

satoshi-ota mentioned this pull request Aug 30, 2022

refactor(planning_launch): update params name for readability tier4/autoware_launch-old#458

Merged

8 tasks

satoshi-ota force-pushed the refactor/params-name-obstacle-stop branch from 4013048 to 15156c8 Compare September 2, 2022 03:23

satoshi-ota added 6 commits September 6, 2022 09:25

refactor(obstacle_stop_planner): update parameter name for readability

344adec

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

docs(obstacle_stop_planner): update module documentation

664cf6e

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

docs(obstacle_stop_planner): update figure

b739253

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

refactor(obstacle_stop_planner): separate params by namespace

a6369bc

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

fix(tier4_planning_launch): separate params by namespace

2f0b824

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

refactor(obstacle_stop_planner): remove default value from declare_pa…

b3f16f7

…rameter Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

satoshi-ota force-pushed the refactor/params-name-obstacle-stop branch from 15156c8 to f5730b8 Compare September 6, 2022 00:36

refactor(obstacle_stop_planner): add params to config

532eb41

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

satoshi-ota force-pushed the refactor/params-name-obstacle-stop branch from f5730b8 to 532eb41 Compare September 6, 2022 00:46

h-ohta approved these changes Sep 6, 2022

View reviewed changes

satoshi-ota merged commit fcf812b into autowarefoundation:main Sep 6, 2022

satoshi-ota deleted the refactor/params-name-obstacle-stop branch September 6, 2022 10:29

tier4-autoware-public-bot bot mentioned this pull request Sep 7, 2022

chore: sync upstream tier4/autoware.universe#100

Merged

sfukuta mentioned this pull request Aug 16, 2023

feat(obstacle_stop): upd obstacle hunting tier4/autoware.universe#733

Closed

7 tasks

technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Dec 26, 2024

Merge pull request autowarefoundation#1720 from tier4/cp-lane-change-…

ef4ee99

…stability perf(lane_change): path stability and correctness

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(obstacle_stop_planner): update params name for readability #1720

refactor(obstacle_stop_planner): update params name for readability #1720

satoshi-ota commented Aug 29, 2022 •

edited

Loading

codecov bot commented Aug 29, 2022 •

edited

Loading

github-actions bot commented Aug 29, 2022

satoshi-ota commented Aug 30, 2022

satoshi-ota commented Aug 30, 2022

h-ohta commented Aug 31, 2022

satoshi-ota commented Sep 1, 2022

satoshi-ota commented Sep 2, 2022

h-ohta commented Sep 2, 2022 •

edited

Loading

satoshi-ota commented Sep 4, 2022

h-ohta commented Sep 4, 2022

satoshi-ota commented Sep 4, 2022 •

edited

Loading

satoshi-ota commented Sep 6, 2022

h-ohta commented Sep 6, 2022

refactor(obstacle_stop_planner): update params name for readability #1720

refactor(obstacle_stop_planner): update params name for readability #1720

Conversation

satoshi-ota commented Aug 29, 2022 • edited Loading

Description

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Aug 29, 2022 • edited Loading

Codecov Report

github-actions bot commented Aug 29, 2022

satoshi-ota commented Aug 30, 2022

satoshi-ota commented Aug 30, 2022

h-ohta commented Aug 31, 2022

satoshi-ota commented Sep 1, 2022

satoshi-ota commented Sep 2, 2022

h-ohta commented Sep 2, 2022 • edited Loading

satoshi-ota commented Sep 4, 2022

h-ohta commented Sep 4, 2022

satoshi-ota commented Sep 4, 2022 • edited Loading

satoshi-ota commented Sep 6, 2022

h-ohta commented Sep 6, 2022

satoshi-ota commented Aug 29, 2022 •

edited

Loading

codecov bot commented Aug 29, 2022 •

edited

Loading

h-ohta commented Sep 2, 2022 •

edited

Loading

satoshi-ota commented Sep 4, 2022 •

edited

Loading