Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_fusion_to_detected_object): make has_twist_covariance enable #1692

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Aug 25, 2022

Description

Add object.kinematics.has_twist_covariance = true; in radar_fusion_to_detected_object package

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1692 (229d15a) into main (a8a58c0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1692      +/-   ##
==========================================
- Coverage   10.73%   10.71%   -0.02%     
==========================================
  Files        1103     1103              
  Lines       78356    78438      +82     
  Branches    18649    18650       +1     
==========================================
- Hits         8409     8404       -5     
- Misses      61033    61119      +86     
- Partials     8914     8915       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.70% <0.00%> (-0.01%) ⬇️ Carriedforward from 23e2d58

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...object/include/radar_fusion_to_detected_object.hpp 0.00% <0.00%> (ø)
...ted_object/src/radar_fusion_to_detected_object.cpp 0.00% <0.00%> (ø)
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 73.58% <0.00%> (-9.44%) ⬇️
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yukkysaito yukkysaito added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 25, 2022
Signed-off-by: scepter914 <scepter914@gmail.com>
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit 4882daf into autowarefoundation:main Sep 10, 2022
@scepter914 scepter914 deleted the fix/radar_converter_has_covariance branch September 10, 2022 06:26
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
tier4#1692)

* add hasTwistCovariance

Signed-off-by: scepter914 <scepter914@gmail.com>

* enable has_twist_covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix to magic number

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
tier4#1692)

* add hasTwistCovariance

Signed-off-by: scepter914 <scepter914@gmail.com>

* enable has_twist_covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix to magic number

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
tier4#1692)

* add hasTwistCovariance

Signed-off-by: scepter914 <scepter914@gmail.com>

* enable has_twist_covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix to magic number

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
tier4#1692)

* add hasTwistCovariance

Signed-off-by: scepter914 <scepter914@gmail.com>

* enable has_twist_covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix to magic number

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants