-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radar_fusion_to_detected_object): make has_twist_covariance enable #1692
fix(radar_fusion_to_detected_object): make has_twist_covariance enable #1692
Conversation
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1692 +/- ##
==========================================
- Coverage 10.73% 10.71% -0.02%
==========================================
Files 1103 1103
Lines 78356 78438 +82
Branches 18649 18650 +1
==========================================
- Hits 8409 8404 -5
- Misses 61033 61119 +86
- Partials 8914 8915 +1
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
perception/radar_fusion_to_detected_object/src/radar_fusion_to_detected_object.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: scepter914 <scepter914@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tier4#1692) * add hasTwistCovariance Signed-off-by: scepter914 <scepter914@gmail.com> * enable has_twist_covariance Signed-off-by: scepter914 <scepter914@gmail.com> * fix to magic number Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
tier4#1692) * add hasTwistCovariance Signed-off-by: scepter914 <scepter914@gmail.com> * enable has_twist_covariance Signed-off-by: scepter914 <scepter914@gmail.com> * fix to magic number Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
tier4#1692) * add hasTwistCovariance Signed-off-by: scepter914 <scepter914@gmail.com> * enable has_twist_covariance Signed-off-by: scepter914 <scepter914@gmail.com> * fix to magic number Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
tier4#1692) * add hasTwistCovariance Signed-off-by: scepter914 <scepter914@gmail.com> * enable has_twist_covariance Signed-off-by: scepter914 <scepter914@gmail.com> * fix to magic number Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
Description
Add
object.kinematics.has_twist_covariance = true;
inradar_fusion_to_detected_object
packagePre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.