-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(build-and-test-differential): disable no-cuda test #1669
Conversation
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is reasonable. LGTM
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this only disables the new jobs from the other pr, it should be ok.
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
…tion#1669) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
This reverts commit 2d62bdf.
autowarefoundation#2410) Revert "ci(build-and-test-differential): disable no-cuda test (autowarefoundation#1669)" This reverts commit 2d62bdf. Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
autowarefoundation#2410) Revert "ci(build-and-test-differential): disable no-cuda test (autowarefoundation#1669)" This reverts commit 2d62bdf. Signed-off-by: kminoda <koji.minoda@tier4.jp>
Description
Due to the number of CI jobs introduced by #1307, many jobs are jammed now. 😢
![image](https://user-images.githubusercontent.com/31987104/186084305-73adf116-5449-49d1-8830-5a726d22f6da.png)
To resolve the jam, I'd like to disable no-cuda test for the differential build.
Even though it disables checks for open PRs, it's still tested daily, and tested after a PR is merged.
Also, if necessary, you can trigger a full-build test whenever you like using
workflow_dispatch
.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.