Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build-and-test-differential): disable no-cuda test #1669

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Aug 23, 2022

Description

Due to the number of CI jobs introduced by #1307, many jobs are jammed now. 😢
image

To resolve the jam, I'd like to disable no-cuda test for the differential build.

Even though it disables checks for open PRs, it's still tested daily, and tested after a PR is merged.
Also, if necessary, you can trigger a full-build test whenever you like using workflow_dispatch.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is reasonable. LGTM

@kenji-miyake
Copy link
Contributor Author

Thank you!
Just in case, I'll wait for comments from other reviewers.

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this only disables the new jobs from the other pr, it should be ok.

@kenji-miyake kenji-miyake enabled auto-merge (squash) August 23, 2022 07:57
@kenji-miyake kenji-miyake disabled auto-merge August 23, 2022 07:57
@kenji-miyake kenji-miyake merged commit 2d62bdf into main Aug 23, 2022
@kenji-miyake kenji-miyake deleted the disable-no-cuda-differential-build branch August 23, 2022 07:58
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…tion#1669)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
kenji-miyake added a commit that referenced this pull request Nov 30, 2022
kenji-miyake added a commit that referenced this pull request Dec 1, 2022
#2410)

Revert "ci(build-and-test-differential): disable no-cuda test (#1669)"

This reverts commit 2d62bdf.
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
autowarefoundation#2410)

Revert "ci(build-and-test-differential): disable no-cuda test (autowarefoundation#1669)"

This reverts commit 2d62bdf.

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
autowarefoundation#2410)

Revert "ci(build-and-test-differential): disable no-cuda test (autowarefoundation#1669)"

This reverts commit 2d62bdf.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants