fix(lane_departure_checker): use common nearest ego search #1611

takayuki5168 · 2022-08-17T14:40:40Z

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

issue
#1581

depends on
tier4/autoware_launch#442
#1590

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

codecov · 2022-08-17T15:00:55Z

Codecov Report

Merging #1611 (725242b) into main (b0d3b9d) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
- Coverage   10.78%   10.55%   -0.23%     
==========================================
  Files        1111     1111              
  Lines       78519    80309    +1790     
  Branches    18552    19837    +1285     
==========================================
+ Hits         8465     8475      +10     
- Misses      61195    62856    +1661     
- Partials     8859     8978     +119

Flag	Coverage Δ		*Carryforward flag
differential	`0.75% <0.00%> (?)`
total	`10.76% <0.00%> (ø)`		Carriedforward from 4871929

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
.../lane_departure_checker/lane_departure_checker.hpp	`0.00% <ø> (ø)`
..._departure_checker_node/lane_departure_checker.cpp	`0.00% <0.00%> (ø)`
...rture_checker_node/lane_departure_checker_node.cpp	`0.41% <0.00%> (ø)`
...nning/behavior_path_planner/src/path_utilities.cpp	`0.00% <0.00%> (ø)`
...ning/behavior_path_planner/src/debug_utilities.cpp	`0.00% <0.00%> (ø)`
.../behavior_path_planner/src/turn_signal_decider.cpp	`0.00% <0.00%> (ø)`
...or_path_planner/src/scene_module/pull_out/util.cpp	`0.00% <0.00%> (ø)`
...nner/src/scene_module/pull_out/pull_out_module.cpp	`0.00% <0.00%> (ø)`
...er/src/scene_module/pull_over/pull_over_module.cpp	`0.00% <0.00%> (ø)`
.../include/behavior_path_planner/debug_utilities.hpp	`0.00% <0.00%> (ø)`
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kyoichi-sugahara · 2022-08-23T22:18:40Z

lane_departure_checker doesn't output emergency

kyoichi-sugahara

LGTM

* fix(lane_departure_checker): use common nearest ego search Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix typo Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

…oundation#1611) * fix(lane_departure_checker): use common nearest ego search Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix typo Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(lane_departure_checker): use common nearest ego search Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix typo Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Revert "feat: improve lanelet search logic in getPredictedReferencePath()" This reverts commit 5de95b0.

* feat(lane_change): cancel hysteresis (autowarefoundation#6288) * feat(lane_change): cancel hysteresis Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update documentation Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix the explanation of the hysteresis count Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Add parked parked RSS Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * support new perception_reproducer Signed-off-by: temkei.kem <1041084556@qq.com> * move files Signed-off-by: temkei.kem <1041084556@qq.com> * remove old files. Signed-off-by: temkei.kem <1041084556@qq.com> * fix pre-commit err Signed-off-by: temkei.kem <1041084556@qq.com> * style(pre-commit): autofix * feat(autoware_behavior_path_planner_common): disable feature of turning off blinker at low velocity (autowarefoundation#1571) Refactor turn signal decider logic and add support for detecting turn signals in turn lanes Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> * fix a small bug about perception reproducer * style(pre-commit): autofix * feat(out_of_lane): ignore lanelets beyond the last path point (autowarefoundation#1554) * feat(out_of_lane): ignore lanelets beyond the last path point Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(behavior_velocity_run_out_module): exclude obstacle crossing ego… (autowarefoundation#1574) feat(behavior_velocity_run_out_module): exclude obstacle crossing ego back line (autowarefoundation#6680) * add method to ignore target obstacles that cross ego cut lane * WIP add debug support * add params and finish debug marker * change lane to line * use autoware utils to get the cut line * simplify code wit calcOffsetPose * Update readme and eliminate unused code * update readme * eliminate unused function * readme * comments and readme * eliminate unused include * typo * rename param for consistency * change lane to line for consistency * rename for clarity, add brief * fix indentation * update description * lane ->line * lane -> line --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * fix(lane_change): change stopping logic (RT0-33761) (autowarefoundation#1581) * RT0-33761 fix lane change stopping logic Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * copied from awf main tested implementation Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * doxygen comment Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update planning/behavior_path_lane_change_module/src/utils/utils.cpp Co-authored-by: mkquda <168697710+mkquda@users.noreply.github.com> --------- Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: mkquda <168697710+mkquda@users.noreply.github.com> * perf: PR 7237 autowarefoundation#7237 * perf RP8406 autowarefoundation#8406 * perf PR 8416 * perf PR 8427 * perf PR 8413 * tool PR 8456 * perf PR 8461 * perf PR 8388 * perf PR 8467 * perf PR 8471 * perf PR 8490 * perf PR 8751 * chore: fix format * perf PR 8657 * feat: improve lanelet search logic in getPredictedReferencePath() * sp develop remove non approved change (autowarefoundation#1611) Revert "feat: improve lanelet search logic in getPredictedReferencePath()" This reverts commit 5de95b0. * feat PR 8811 * fix PR 8973 * feat: improve lanelet search logic in getPredictedReferencePath() --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: temkei.kem <1041084556@qq.com> Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> Co-authored-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: temkei.kem <1041084556@qq.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp> Co-authored-by: mkquda <168697710+mkquda@users.noreply.github.com> Co-authored-by: Shohei Sakai <saka1s.jp@gmail.com>

fix(lane_departure_checker): use common nearest ego search

4871929

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

takayuki5168 marked this pull request as ready for review August 17, 2022 14:41

fix typo

725242b

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

takayuki5168 requested review from TakaHoribe and kyoichi-sugahara August 17, 2022 15:00

kyoichi-sugahara approved these changes Aug 23, 2022

View reviewed changes

kyoichi-sugahara merged commit ba02755 into autowarefoundation:main Aug 24, 2022

kyoichi-sugahara deleted the fix/lane-departure-nearest-ego branch August 24, 2022 19:50

tier4-autoware-public-bot bot mentioned this pull request Aug 25, 2022

chore: sync upstream tier4/autoware.universe#91

Merged

takayuki5168 mentioned this pull request Oct 20, 2022

Deal with U-turn and crossing path #1581

Open

3 tasks

technolojin added a commit to technolojin/autoware.universe that referenced this pull request Oct 29, 2024

sp develop remove non approved change (autowarefoundation#1611)

4fb0d67

Revert "feat: improve lanelet search logic in getPredictedReferencePath()" This reverts commit 5de95b0.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(lane_departure_checker): use common nearest ego search #1611

fix(lane_departure_checker): use common nearest ego search #1611

takayuki5168 commented Aug 17, 2022 •

edited

Loading

codecov bot commented Aug 17, 2022 •

edited

Loading

kyoichi-sugahara commented Aug 23, 2022

kyoichi-sugahara left a comment

fix(lane_departure_checker): use common nearest ego search #1611

fix(lane_departure_checker): use common nearest ego search #1611

Conversation

takayuki5168 commented Aug 17, 2022 • edited Loading

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Aug 17, 2022 • edited Loading

Codecov Report

kyoichi-sugahara commented Aug 23, 2022

kyoichi-sugahara left a comment

Choose a reason for hiding this comment

takayuki5168 commented Aug 17, 2022 •

edited

Loading

codecov bot commented Aug 17, 2022 •

edited

Loading