Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ekf_localizer): modified std deviation to deviation #1565

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

cyn-liu
Copy link
Contributor

@cyn-liu cyn-liu commented Aug 10, 2022

Signed-off-by: cyn-liu cynthia.liu@autocore.ai

Description

modified std deviation to deviation, avoid unnecessary computational resource consumption.
related link #1562

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@YamatoAndo YamatoAndo requested a review from kminoda August 10, 2022 11:01
@YamatoAndo YamatoAndo added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1565 (d1a9774) into main (b087957) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1565   +/-   ##
=======================================
  Coverage   10.72%   10.72%           
=======================================
  Files        1115     1115           
  Lines       78832    78832           
  Branches    18561    18561           
=======================================
  Hits         8454     8454           
  Misses      61516    61516           
  Partials     8862     8862           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.70% <0.00%> (ø) Carriedforward from 90443a4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <0.00%> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cyn-liu cyn-liu changed the title fix(ekf_localizer):modified std deviation to deviation fix(ekf_localizer): modified std deviation to deviation Aug 12, 2022
@kminoda
Copy link
Contributor

kminoda commented Aug 15, 2022

Please fix the link to the issue in the description (to this: #1562)

….hpp

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sharrrrk Sharrrrk merged commit b6d88ea into autowarefoundation:main Aug 15, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* issue1562:modified std deviation to deviation

* ci(pre-commit): autofix

* Update localization/ekf_localizer/include/ekf_localizer/ekf_localizer.hpp

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* issue1562:modified std deviation to deviation

* ci(pre-commit): autofix

* Update localization/ekf_localizer/include/ekf_localizer/ekf_localizer.hpp

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* issue1562:modified std deviation to deviation

* ci(pre-commit): autofix

* Update localization/ekf_localizer/include/ekf_localizer/ekf_localizer.hpp

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…dation#1565)

* issue1562:modified std deviation to deviation

* ci(pre-commit): autofix

* Update localization/ekf_localizer/include/ekf_localizer/ekf_localizer.hpp

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* issue1562:modified std deviation to deviation

* ci(pre-commit): autofix

* Update localization/ekf_localizer/include/ekf_localizer/ekf_localizer.hpp

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants