-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_palnner): update geometric parallel parking for pull_out module #1534
feat(behavior_path_palnner): update geometric parallel parking for pull_out module #1534
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1534 +/- ##
========================================
Coverage 10.72% 10.72%
========================================
Files 1103 1103
Lines 78362 78408 +46
Branches 18647 18653 +6
========================================
+ Hits 8405 8410 +5
+ Misses 61176 61085 -91
- Partials 8781 8913 +132
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
5becaa4
to
6a1088d
Compare
1d8dd3f
to
2116899
Compare
b447a0f
to
229385c
Compare
@kosuke55 can you update readme? |
@yukkysaito |
planning/behavior_path_planner/src/scene_module/utils/geometric_parallel_parking.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pls get approval by @TakaHoribe
@yukkysaito @TakaHoribe |
e15ea1e
to
c028e93
Compare
c028e93
to
60b1272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Memo: this PR enables the geometryc_parking in the pull_out module as well as the pull_over.
0b64e29
to
df92605
Compare
…ll_out module Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
df92605
to
e2539a6
Compare
…ll_out module (tier4#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ll_out module (tier4#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ll_out module (tier4#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ll_out module (#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ll_out module (#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ll_out module (autowarefoundation#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ll_out module (#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ll_out module (tier4#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ll_out module (#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ll_out module (#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ll_out module (#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ll_out module (#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ll_out module (#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* feat(behavior_path_palnner): update geometric parallel parking for pull_out module (autowarefoundation#1534) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat(behavior_path_planner): update pull out (autowarefoundation#1438) * feat(behavior_path_planner): update pull out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * refactor(behavior_path_planner): rename pull_out params Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update from review Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use debug_data Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * enable back Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * move PlannerType Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix debug marker Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add seach priority Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * change before_pull_out_straight_distance to 0.0 Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat(motion_utils): add isDrivingForward function (autowarefoundation#1360) * feat(motion_utils: add isDrivingForward function Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * implemented isDrivingForward Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * use isDrivingForward in each module Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * feat(tier4_autoware_utils): add setter/getter of longitudinal velocity Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * added test Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: kosuke55 <kosuke.tnp@gmail.com> * fix(tier4_planning_rviz_plugin): support backward driving in path/traj plugin (autowarefoundation#1335) * fix(tier4_planning_rviz_plugin): support backward driving in path_with_lane_id/path/trajectory plugin Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add utils.hpp Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id (autowarefoundation#1735) * feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix pre-commit Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update pull out default th_stopped_time Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
…ain-sync chore: sync beta branch beta/v0.34 with tier4/main
Signed-off-by: kosuke55 kosuke.tnp@gmail.com
Description
This PR is the part of #1438.
Update geoemetric_parallel_parking for pull_out and update pull_over accordingly.
The behavior of pull_over will not change.
planDeparting
which is the reverse of parking.Related links
part of #1438
merge #1571 first : done
launcher: tier4/autoware_launch#431
Tests performed
psim
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.