Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_palnner): update geometric parallel parking for pull_out module #1534

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 8, 2022

Signed-off-by: kosuke55 kosuke.tnp@gmail.com

Description

This PR is the part of #1438.
Update geoemetric_parallel_parking for pull_out and update pull_over accordingly.
The behavior of pull_over will not change.

  • add planDeparting which is the reverse of parking.
  • make some variable parameters.
  • refactoring
  • change pull over max_steer_rad 40deg to 20deg(Some individuals are unable to steer 40deg when stopped.)
  • fix lane_id of arc path. add road and shoulder lane ids to arc path.

Related links

part of #1438
merge #1571 first : done
launcher: tier4/autoware_launch#431

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #1534 (8efee47) into main (43c01e1) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 8efee47 differs from pull request most recent head c028e93. Consider uploading reports for the commit c028e93 to get more accurate results

@@           Coverage Diff            @@
##             main    #1534    +/-   ##
========================================
  Coverage   10.72%   10.72%            
========================================
  Files        1103     1103            
  Lines       78362    78408    +46     
  Branches    18647    18653     +6     
========================================
+ Hits         8405     8410     +5     
+ Misses      61176    61085    -91     
- Partials     8781     8913   +132     
Flag Coverage Δ
total 10.71% <0.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
system/default_ad_api/src/interface.cpp 71.42% <0.00%> (ø)
common/osqp_interface/src/osqp_interface.cpp 34.35% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)
planning/rtc_interface/src/rtc_interface.cpp 0.00% <0.00%> (ø)
control/trajectory_follower/src/mpc_utils.cpp 58.25% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.43% <0.00%> (ø)
common/motion_utils/src/marker/marker_helper.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 1.04% <0.00%> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.25% <0.00%> (ø)
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
... and 84 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kosuke55 kosuke55 force-pushed the feature/update_geometric_parallel_parking branch 2 times, most recently from 5becaa4 to 6a1088d Compare August 11, 2022 02:35
@kosuke55 kosuke55 marked this pull request as ready for review August 12, 2022 04:36
@kosuke55 kosuke55 force-pushed the feature/update_geometric_parallel_parking branch from 1d8dd3f to 2116899 Compare August 13, 2022 05:00
@kosuke55 kosuke55 force-pushed the feature/update_geometric_parallel_parking branch 3 times, most recently from b447a0f to 229385c Compare August 17, 2022 09:55
@yukkysaito
Copy link
Contributor

@kosuke55 can you update readme?

@kosuke55
Copy link
Contributor Author

@yukkysaito
yes, I updated README in
#1578 for pull_over
#1587 for pull_out

@yukkysaito yukkysaito self-requested a review August 19, 2022 02:02
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
pls get approval by @TakaHoribe

@kosuke55
Copy link
Contributor Author

@yukkysaito @TakaHoribe
Thanks, please check also launcher tier4/autoware_launch#431

@kosuke55 kosuke55 force-pushed the feature/update_geometric_parallel_parking branch 4 times, most recently from e15ea1e to c028e93 Compare August 25, 2022 07:20
@kosuke55 kosuke55 force-pushed the feature/update_geometric_parallel_parking branch from c028e93 to 60b1272 Compare August 29, 2022 06:53
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Memo: this PR enables the geometryc_parking in the pull_out module as well as the pull_over.

@TakaHoribe TakaHoribe changed the title feat(behavior_path_palnner): update geometric parallel parking feat(behavior_path_palnner): update geometric parallel parking for pull_out module Aug 29, 2022
@kosuke55 kosuke55 force-pushed the feature/update_geometric_parallel_parking branch from 0b64e29 to df92605 Compare August 29, 2022 09:46
…ll_out module

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feature/update_geometric_parallel_parking branch from df92605 to e2539a6 Compare August 29, 2022 09:50
@kosuke55 kosuke55 merged commit 687be97 into autowarefoundation:main Aug 30, 2022
@kosuke55 kosuke55 deleted the feature/update_geometric_parallel_parking branch August 30, 2022 05:35
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…ll_out module (tier4#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ll_out module (tier4#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ll_out module (tier4#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
…ll_out module (#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 14, 2022
…ll_out module (#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ll_out module (autowarefoundation#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 18, 2022
…ll_out module (#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…ll_out module (tier4#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 10, 2022
…ll_out module (#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 30, 2022
…ll_out module (#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Jan 23, 2023
…ll_out module (#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Jan 23, 2023
…ll_out module (#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Jan 23, 2023
…ll_out module (#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 24, 2023
* feat(behavior_path_palnner): update geometric parallel parking for pull_out module (autowarefoundation#1534)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(behavior_path_planner): update pull out (autowarefoundation#1438)

* feat(behavior_path_planner): update pull out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* refactor(behavior_path_planner): rename pull_out params

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update from review

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* use debug_data

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* enable back

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* move PlannerType

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix debug marker

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add seach priority

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* change before_pull_out_straight_distance to 0.0

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(motion_utils): add isDrivingForward function (autowarefoundation#1360)

* feat(motion_utils: add isDrivingForward function

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* implemented isDrivingForward

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* use isDrivingForward in each module

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(tier4_autoware_utils): add setter/getter of longitudinal velocity

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* added test

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>

* fix(tier4_planning_rviz_plugin): support backward driving in path/traj plugin (autowarefoundation#1335)

* fix(tier4_planning_rviz_plugin): support backward driving in path_with_lane_id/path/trajectory plugin

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add utils.hpp

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id (autowarefoundation#1735)

* feat(tier4_planning_rviz_plugin): add velocity_text to path_with_lane_id

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix pre-commit

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* update pull out default th_stopped_time

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Oct 28, 2024
…ain-sync

chore: sync beta branch beta/v0.34 with tier4/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants