-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scan_ground_filter): fix segmentation fault #1503
fix(scan_ground_filter): fix segmentation fault #1503
Conversation
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Codecov Report
@@ Coverage Diff @@
## main #1503 +/- ##
=========================================
- Coverage 10.30% 9.63% -0.67%
=========================================
Files 1128 1096 -32
Lines 72707 77185 +4478
Branches 17929 17705 -224
=========================================
- Hits 7489 7440 -49
- Misses 57449 62504 +5055
+ Partials 7769 7241 -528
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
I confirmed this node is not terminated and works well with rosbag replay simulation. |
* feat(scan_ground_filter): fix segfault Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * change using sentence Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * fix Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * remove unused code Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
fix(scan_ground_filter): fix segmentation fault (#1503)
* feat(scan_ground_filter): fix segfault Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * change using sentence Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * fix Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * remove unused code Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
) * feat(scan_ground_filter): fix segfault Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * change using sentence Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * fix Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * remove unused code Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
* feat(scan_ground_filter): fix segfault Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * change using sentence Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * fix Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * remove unused code Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
* feat(scan_ground_filter): fix segfault Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * change using sentence Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * fix Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * remove unused code Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
* feat(scan_ground_filter): fix segfault Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * change using sentence Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * fix Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * remove unused code Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
* feat(scan_ground_filter): fix segfault Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * change using sentence Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * fix Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * remove unused code Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
) * feat(scan_ground_filter): fix segfault Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * change using sentence Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * fix Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * remove unused code Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
* feat(scan_ground_filter): fix segfault Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * change using sentence Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * fix Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * remove unused code Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
…cherry-pick-bpp fix(bpp): use common steering factor interface for same scene modules (autowarefoundation#8675)
Description
Fix segmentation fault due to access violation in out_radial_ordered_points[radial_div]
Test procedure
Run rosbag replay simulation with sample-bag and other rosbags to verify that the scan ground filter is not terminated.
Tested with rosbag, which was causing the segmentation fault, and confirmed that there was no problem.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.