Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_control_launch): declare param path argument #1432

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 26, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

set tier4_control_launch_param_path in control.launch.xml

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review July 26, 2022 05:56
@takayuki5168
Copy link
Contributor Author

I've verified this PR works well with planning simulator

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit 99a4ea6 into autowarefoundation:main Jul 26, 2022
@takayuki5168 takayuki5168 deleted the feat/control-param-path branch July 26, 2022 06:34
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…dation#1432)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Jul 31, 2024
* feat(evalautor): rename evaluator diag topics (autowarefoundation#8152)

* feat(evalautor): rename evaluator diag topics

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* perception

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix: adapt v0.29.0 control launcher

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants