Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(motion_utils): fix pose in interpolated pose function #1402

Merged
merged 3 commits into from
Jul 25, 2022
Merged

feat(motion_utils): fix pose in interpolated pose function #1402

merged 3 commits into from
Jul 25, 2022

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jul 22, 2022 •
edited
Loading

Signed-off-by: yutaka purewater0901@gmail.com

Description

Add driving forward check function and fix orientation function in calcInterpolatedPose function

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@purewater0901
feat(motion_utils): fix pose in interpolated pose function
5cf969b 
Signed-off-by: yutaka <purewater0901@gmail.com>
@codecov
Copy link

codecov bot commented Jul 22, 2022 •
edited
Loading

Codecov Report

Merging #1402 (28d3bde) into main (01ad83a) will increase coverage by 0.44%.
The diff coverage is 75.71%.

@@            Coverage Diff            @@
##            main    #1402      +/-   ##
=========================================
+ Coverage   9.97%   10.41%   +0.44%     
=========================================
  Files       1120     1120              
  Lines      77767    78234     +467     
  Branches   17838    18090     +252     
=========================================
+ Hits        7759     8150     +391     
- Misses     62669    62673       +4     
- Partials    7339     7411      +72
Flag Coverage Δ *Carryforward flag
differential 10.58% <77.08%> (?)
total 9.96% <55.81%> (ø) Carriedforward from 0043566

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...autoware_utils/test/src/geometry/test_geometry.cpp 45.05% <67.30%> (+4.35%) ⬆️
...ils/include/motion_utils/trajectory/trajectory.hpp 80.98% <100.00%> (+2.62%) ⬆️
...include/tier4_autoware_utils/geometry/geometry.hpp 96.08% <100.00%> (+0.77%) ⬆️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 83.01% <0.00%> (+18.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ad83a...28d3bde. Read the comment docs.

takayuki5168
takayuki5168 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 123a472 into autowarefoundation:main Jul 25, 2022
@purewater0901 purewater0901 deleted the feat/fix-orientaion-in-interpolation branch July 25, 2022 07:06
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 26, 2022
Merged
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@purewater0901 @boyali
feat(motion_utils): fix pose in interpolated pose function (tier4#1402)
71c2502 
* feat(motion_utils): fix pose in interpolated pose function

Signed-off-by: yutaka <purewater0901@gmail.com>

* replace the isDriving funciton with tier4_autoware_utils

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@purewater0901 @boyali
feat(motion_utils): fix pose in interpolated pose function (tier4#1402)
5fdd86e 
* feat(motion_utils): fix pose in interpolated pose function

Signed-off-by: yutaka <purewater0901@gmail.com>

* replace the isDriving funciton with tier4_autoware_utils

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@purewater0901 @boyali
feat(motion_utils): fix pose in interpolated pose function (tier4#1402)
110198e 
* feat(motion_utils): fix pose in interpolated pose function

Signed-off-by: yutaka <purewater0901@gmail.com>

* replace the isDriving funciton with tier4_autoware_utils

Signed-off-by: yutaka <purewater0901@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 14, 2022
@purewater0901 @1222-takeshi
feat(motion_utils): fix pose in interpolated pose function (#1402)
eb555cf 
* feat(motion_utils): fix pose in interpolated pose function

Signed-off-by: yutaka <purewater0901@gmail.com>

* replace the isDriving funciton with tier4_autoware_utils

Signed-off-by: yutaka <purewater0901@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@purewater0901
feat(motion_utils): fix pose in interpolated pose function (autowaref…
d6da2b2 
…oundation#1402)

* feat(motion_utils): fix pose in interpolated pose function

Signed-off-by: yutaka <purewater0901@gmail.com>

* replace the isDriving funciton with tier4_autoware_utils

Signed-off-by: yutaka <purewater0901@gmail.com>
@1222-takeshi 1222-takeshi mentioned this pull request Oct 14, 2022
Closed
4 tasks
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 18, 2022
@purewater0901 @1222-takeshi
feat(motion_utils): fix pose in interpolated pose function (#1402)
feefa29 
* feat(motion_utils): fix pose in interpolated pose function

Signed-off-by: yutaka <purewater0901@gmail.com>

* replace the isDriving funciton with tier4_autoware_utils

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@purewater0901 @boyali
feat(motion_utils): fix pose in interpolated pose function (tier4#1402)
f69262b 
* feat(motion_utils): fix pose in interpolated pose function

Signed-off-by: yutaka <purewater0901@gmail.com>

* replace the isDriving funciton with tier4_autoware_utils

Signed-off-by: yutaka <purewater0901@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 10, 2022
@purewater0901 @kosuke55
feat(motion_utils): fix pose in interpolated pose function (#1402)
51df783 
* feat(motion_utils): fix pose in interpolated pose function

Signed-off-by: yutaka <purewater0901@gmail.com>

* replace the isDriving funciton with tier4_autoware_utils

Signed-off-by: yutaka <purewater0901@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 30, 2022
@purewater0901 @kosuke55
feat(motion_utils): fix pose in interpolated pose function (#1402)
2b3f3a4 
* feat(motion_utils): fix pose in interpolated pose function

Signed-off-by: yutaka <purewater0901@gmail.com>

* replace the isDriving funciton with tier4_autoware_utils

Signed-off-by: yutaka <purewater0901@gmail.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Jul 10, 2024
@technolojin
fix(multi_object_tracker): fix publish interval adjust timing (autowa…
49d0c35 
…refoundation#1402)

fix(multi_object_tracker): fix publish interval adjust timing (autowarefoundation#7904)

refactor: optimize publish time check in multi_object_tracker_node.cpp

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purewater0901 @takayuki5168