Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tier4_perception_launch): declare param path argument #1394

Merged
merged 4 commits into from
Jul 27, 2022
Merged

feat(tier4_perception_launch): declare param path argument #1394

merged 4 commits into from
Jul 27, 2022

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 21, 2022 •
edited
Loading

Description

set tier4_perception_launch_param_path argument

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 force-pushed the feat/perception-param-path branch from 7b39b68 to 99b5744 Compare July 21, 2022 07:18
@takayuki5168
feat(tier4_perception_launch): declare param path argument
ff08f63 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/perception-param-path branch from 99b5744 to ff08f63 Compare July 25, 2022 14:58
@takayuki5168 takayuki5168 marked this pull request as ready for review July 25, 2022 14:58
@takayuki5168 takayuki5168 changed the title Feat/perception param path feat(tier4_perception_launch): declare param path argument Jul 25, 2022
@codecov
Copy link

codecov bot commented Jul 25, 2022 •
edited
Loading

Codecov Report

Merging #1394 (311efdb) into main (34a74ab) will not change coverage.
The diff coverage is n/a.

❗ Current head 311efdb differs from pull request most recent head 1941bea. Consider uploading reports for the commit 1941bea to get more accurate results

@@           Coverage Diff           @@
##             main    #1394   +/-   ##
=======================================
  Coverage   10.09%   10.09%           
=======================================
  Files        1117     1117           
  Lines       77231    77231           
  Branches    17853    17853           
=======================================
  Hits         7793     7793           
  Misses      62090    62090           
  Partials     7348     7348
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 10.07% <ø> (ø) Carriedforward from ed33b9f

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a74ab...1941bea. Read the comment docs.

yukkysaito
yukkysaito approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168
Update launch/tier4_perception_launch/launch/perception.launch.xml
ed33b9f
@takayuki5168
fix ci error
311efdb 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
fix ci error
1941bea 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 mentioned this pull request Jul 26, 2022
Closed
6 tasks
@takayuki5168 takayuki5168 merged commit 156d005 into autowarefoundation:main Jul 27, 2022
@takayuki5168 takayuki5168 deleted the feat/perception-param-path branch July 27, 2022 02:34
@isamu-takagi
Copy link
Contributor

@takayuki5168 This lines causes following error.
TypeError: add_launch_arg() takes from 1 to 2 positional arguments but 3 were given

@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 28, 2022
Merged
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@takayuki5168 @boyali
feat(tier4_perception_launch): declare param path argument (tier4#1394)
c4666d3 
* feat(tier4_perception_launch): declare param path argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@takayuki5168 @boyali
feat(tier4_perception_launch): declare param path argument (tier4#1394)
51d4af0 
* feat(tier4_perception_launch): declare param path argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@takayuki5168 @boyali
feat(tier4_perception_launch): declare param path argument (tier4#1394)
b0bec99 
* feat(tier4_perception_launch): declare param path argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@takayuki5168
feat(tier4_perception_launch): declare param path argument (autowaref…
a5cb267 
…oundation#1394)

* feat(tier4_perception_launch): declare param path argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@takayuki5168 @boyali
feat(tier4_perception_launch): declare param path argument (tier4#1394)
b00cc7b 
* feat(tier4_perception_launch): declare param path argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix ci error

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Oct 28, 2024
@maxime-clem
fix(motion_planning): fix processing time topic names (autowarefounda…
7777632 
…tion#7885) (autowarefoundation#1394)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@kenji-miyake kenji-miyake Awaiting requested review from kenji-miyake

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takayuki5168 @isamu-takagi @yukkysaito