Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin #1387

Merged
merged 3 commits into from
Jul 21, 2022
Merged

fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin #1387

merged 3 commits into from
Jul 21, 2022
+6 −4

Conversation

1222-takeshi
Copy link
Contributor

@1222-takeshi 1222-takeshi commented Jul 21, 2022 •
edited
Loading

Signed-off-by: Takeshi Miura m.takeshi1995@gmail.com

Description

Fixed a problem with initialization at rviz startup not working in environments without nvidia driver.
Before
image

After
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@1222-takeshi
fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin
10c51e6 
Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>
@codecov
Copy link

codecov bot commented Jul 21, 2022 •
edited
Loading

Codecov Report

Merging #1387 (df3c317) into main (c834f05) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1387      +/-   ##
========================================
- Coverage   9.92%   9.91%   -0.01%     
========================================
  Files       1117    1117              
  Lines      77941   77968      +27     
  Branches   18087   18087              
========================================
  Hits        7734    7734              
- Misses     62677   62704      +27     
  Partials    7530    7530
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.90% <0.00%> (ø) Carriedforward from dfc9164

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r4_planning_rviz_plugin/src/tools/max_velocity.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c834f05...df3c317. Read the comment docs.

@1222-takeshi 1222-takeshi marked this pull request as ready for review July 21, 2022 04:49
@1222-takeshi
remove comment out
df3c317 
Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>
tkimura4
tkimura4 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1222-takeshi 1222-takeshi merged commit b23f418 into autowarefoundation:main Jul 21, 2022
@1222-takeshi 1222-takeshi deleted the fix/initialization-planning-rviz-plugin branch July 21, 2022 05:16
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 22, 2022
Merged
1222-takeshi referenced this pull request in tier4/autoware.universe Aug 5, 2022
@1222-takeshi @pre-commit-ci
fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin (#…
85fcc94 
…1387)

* fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* remove comment out

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
tkimura4 referenced this pull request in tier4/autoware.universe Sep 8, 2022
@1222-takeshi @pre-commit-ci @tkimura4
fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin (#…
89ddac8 
…1387)

* fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* remove comment out

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@tkimura4 tkimura4 mentioned this pull request Sep 8, 2022
Merged
4 tasks
tkimura4 referenced this pull request in tier4/autoware.universe Sep 8, 2022
@tkimura4 @1222-takeshi @pre-commit-ci
fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin …
0b04db4 
…(autowarefoundation#1387) (#112)

fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin (#1387)

* fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* remove comment out

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@1222-takeshi @pre-commit-ci @boyali
fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin (t…
f033e0f 
…ier4#1387)

* fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* remove comment out

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@1222-takeshi @pre-commit-ci @boyali
fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin (t…
812d22d 
…ier4#1387)

* fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* remove comment out

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@1222-takeshi @pre-commit-ci @boyali
fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin (t…
2e85b04 
…ier4#1387)

* fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* remove comment out

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@1222-takeshi @pre-commit-ci
fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin (a…
7bfac21 
…utowarefoundation#1387)

* fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* remove comment out

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@1222-takeshi @pre-commit-ci @boyali
fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin (t…
0b3ae3a 
…ier4#1387)

* fix(tier4_planning_rviz_plugin): fix initialize planning_rviz_plugin

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

* ci(pre-commit): autofix

* remove comment out

Signed-off-by: Takeshi Miura <m.takeshi1995@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkimura4 tkimura4 tkimura4 approved these changes

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1222-takeshi @tkimura4