Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner): lerp stop point z coordinate #1370

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 19, 2022

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

  • fix stop point z position (use lerp)

Before (use z position of the front point)

image

After (lerp z position)

rviz_screenshot_2022_07_19-16_45_37

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota marked this pull request as ready for review July 19, 2022 07:52
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this fix by psim LGTM
before
image (2)

after
image

@satoshi-ota satoshi-ota enabled auto-merge (squash) July 19, 2022 08:24
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1370 (af8aeed) into main (c88528d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1370      +/-   ##
========================================
- Coverage   9.66%   9.63%   -0.03%     
========================================
  Files       1094    1094              
  Lines      76981   77200     +219     
  Branches   17719   17882     +163     
========================================
  Hits        7440    7440              
- Misses     62299   62506     +207     
- Partials    7242    7254      +12     
Flag Coverage Δ *Carryforward flag
differential 4.94% <0.00%> (?)
total 9.64% <0.00%> (ø) Carriedforward from c88528d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/src/scene_module/crosswalk/scene_crosswalk.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88528d...af8aeed. Read the comment docs.

@satoshi-ota satoshi-ota merged commit e4a86e9 into autowarefoundation:main Jul 19, 2022
taikitanaka3 referenced this pull request in tier4/autoware.universe Jul 19, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota deleted the fix/crosswalk-z-interpolation branch July 19, 2022 23:28
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Jul 2, 2024
…n_pose_instability_detector

fix(pose_instability_detector): fix a crash bug in pose_instability_detector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants