fix(obstacle_cruise_planner): fix node dying

[takayuki5168]

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

[component_container_mt-50] terminate called after throwing an instance of 'std::out_of_range'
[component_container_mt-50]   what():  vector::_M_range_check: __n (which is 146) >= this->size() (which is 146)
[ERROR] [component_container_mt-50]: process has died [pid 1812534, exit code -6, cmd '/opt/ros/galactic/lib/rclcpp_components/component_container_mt --ros-args -r __node:=motion_planning_container -r __ns:=/planning/scenario_planning/lane_driving/motion_planning --params-file /tmp/launch_params_tybtn0if'].

This is caused by invalid access of this code when *start_idx == points.size() - 1.

tier4_autoware_utils::calcDistance2d(points.at(i), points.at(i + 1));

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[tkimura4]

I confirmed that motion_planning_container did not died by planning_simulator.

[codecov]

Codecov Report

Merging #1332 (c334630) into main (27e2664) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1332      +/-   ##
========================================
- Coverage   9.54%   9.54%   -0.01%     
========================================
  Files       1096    1096              
  Lines      76557   76559       +2     
  Branches   17207   17207              
========================================
  Hits        7310    7310              
- Misses     62435   62437       +2     
  Partials    6812    6812              

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	9.53% <0.00%> (ø)		Carriedforward from 27e2664

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...lanner/scene_module/pull_over/pull_over_module.hpp	0.00% <ø> (ø)
...er/scene_module/scene_module_bt_node_interface.hpp	0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp	0.22% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp	0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp	0.00% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp	0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp	0.00% <0.00%> (ø)
...rc/scene_module/scene_module_bt_node_interface.cpp	0.00% <ø> (ø)
.../src/scene_module/side_shift/side_shift_module.cpp	0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp	1.05% <0.00%> (ø)
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a9bc83...c334630. Read the comment docs.